Merge lp://staging/~brendan-donegan/checkbox-certification/bug1185852 into lp://staging/checkbox-certification

Proposed by Brendan Donegan
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 595
Merged at revision: 595
Proposed branch: lp://staging/~brendan-donegan/checkbox-certification/bug1185852
Merge into: lp://staging/checkbox-certification
Diff against target: 43 lines (+11/-10)
2 files modified
debian/changelog (+2/-0)
plugins/certify_prompt.py (+9/-10)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox-certification/bug1185852
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+166733@code.staging.launchpad.net

Description of the change

If the secure ID of the system was pre-filled in the config file then Checkbox would skip the submission screen and just send the submission. Now, since we have a submit to Hexr button on that screen and also display the status URL, we don't want to do this.

Modify certify_prompt to remove the part of the if statement that skipped calling show_entry if the secure ID was already set.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks all right, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches