Merge lp://staging/~brendan-donegan/checkbox-certification/bug1173086_submit_to_hexr_unset into lp://staging/checkbox-certification
Proposed by
Brendan Donegan
| Status: | Merged |
|---|---|
| Approved by: | Zygmunt Krynicki |
| Approved revision: | 587 |
| Merged at revision: | 587 |
| Proposed branch: | lp://staging/~brendan-donegan/checkbox-certification/bug1173086_submit_to_hexr_unset |
| Merge into: | lp://staging/checkbox-certification |
| Diff against target: |
25 lines (+4/-1) 2 files modified
debian/changelog (+3/-1) plugins/certify_prompt.py (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/checkbox-certification/bug1173086_submit_to_hexr_unset |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
I forgot to consider the case of headless execution when updating the certify_prompt plugin to handle the new submitToHexr code. submitToHexr was therefore only getting set in the code section that is called if the submission ID needs to be prompted for in the UI. I set it to a default value of False at the top of the function to make sure it's always set in some way.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1