checkbox-certification

Merge lp://staging/~brendan-donegan/checkbox-certification/bug1091689 into lp://staging/checkbox-certification

  1. bug1091689
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Merged
Merged at revision: 561
Proposed branch: lp://staging/~brendan-donegan/checkbox-certification/bug1091689
Merge into: lp://staging/checkbox-certification
Diff against target: 23 lines (+1/-1)
2 files modified
bin/checkbox-certification-submit (+0/-1)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox-certification/bug1091689
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+140478@code.staging.launchpad.net

Description of the change

There was an oversight in checkbox-certification-submit where the server response was being used before checking whether it was None or not, as is the case when the server cannot be reached. This merge removed the line which shows the status returned by the server - this is only relevant if there was an error, and the status is printed anyway if that is the case.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Awesome and straightforward, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches