checkbox-certification

Merge lp://staging/~brendan-donegan/checkbox-certification/bug1087305 into lp://staging/checkbox-certification

  1. bug1087305
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 560
Merged at revision: 559
Proposed branch: lp://staging/~brendan-donegan/checkbox-certification/bug1087305
Merge into: lp://staging/checkbox-certification
Diff against target: 22 lines (+4/-0)
2 files modified
debian/changelog (+3/-0)
gtk/autostart/checkbox-certification-client.desktop (+1/-0)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox-certification/bug1087305
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Brendan Donegan (community) Needs Resubmitting
Review via email: mp+139872@code.staging.launchpad.net

Description of the change

Add Hidden key to checkbox-certification-client.desktop so that in normal use, checkbox-certification-client does not run automatically when the system reboots. This is only useful for automated runs initiated by checkbox-satellite, so should be enabled by checkbox-satellite itself.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

According to setup.py, you touched the wrong file:

setup.py: ("/etc/xdg/autostart/", ["gtk/autostart/*"]),

The patch must be applied on gtk/autostart/checkbox-certification-client.desktop (the desktop file with the 60s delay)

review: Needs Fixing
lp://staging/~brendan-donegan/checkbox-certification/bug1087305 updated
560. By Brendan Donegan

Move Hidden field to right .desktop file

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Thanks for spotting that - phew!

review: Needs Resubmitting
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches