Code review comment for lp://staging/~brendan-donegan/cdts/packaging

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

After building the package locally using debuild -b -us -uc, lintian warned me about several files installed in /opt:

[...]
Now running lintian...
E: driver-testing: missing-dependency-on-libc needed by usr/bin/driver-testing and 1 others
E: driver-testing: dir-or-file-in-opt opt/driver-testing/
E: driver-testing: dir-or-file-in-opt opt/share/
E: driver-testing: dir-or-file-in-opt opt/share/driver-testing/
E: driver-testing: dir-or-file-in-opt opt/share/driver-testing/qml/
E: driver-testing: dir-or-file-in-opt opt/share/driver-testing/qml/DemoWarnings.qml
[...]
E: driver-testing: dir-or-file-in-opt opt/share/driver-testing/qml/driver-testing.qml
W: driver-testing: binary-without-manpage usr/bin/driver-testing
Finished running lintian.
[...]

It does not prevent the package to be installed or work correctly.

I'm suspecting plainbox-gui/driver-testing/qtquick2applicationviewer/qtquick2applicationviewer.pri because of this line:
installPrefix = /opt/$${TARGET}
But I'm not enterly sure.

Anyway, +1 Great work.

review: Approve

« Back to merge proposal