Merge lp://staging/~brendan-donegan/cdts/ihv_whitelists into lp://staging/cdts

Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2283
Merged at revision: 2290
Proposed branch: lp://staging/~brendan-donegan/cdts/ihv_whitelists
Merge into: lp://staging/cdts
Diff against target: 287 lines (+272/-0)
3 files modified
plainbox-gui/data/ihv-audio.whitelist (+85/-0)
plainbox-gui/data/ihv-graphics.whitelist (+118/-0)
plainbox-gui/data/ihv-wireless.whitelist (+69/-0)
To merge this branch: bzr merge lp://staging/~brendan-donegan/cdts/ihv_whitelists
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+183593@code.staging.launchpad.net

Description of the change

Add the IHV whitelists from the old checkbox-ihv package

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Hmmm looks like some of the files required for creating the offline tarball also got mixed in. Maybe we want to keep those though?

Revision history for this message
Daniel Manrique (roadmr) wrote :

Actually I'd prefer to remove those files (libvirt.xml and preseed.txt), they're no longer needed with the new version of dpkg_offline I'm working on, and would just introduce noise.

Also a question about how we'll handle this. Previously we had checkbox-ihv-{graphics,wireless,audio} packages which contained the corresponding whitelist as well as declaring all the dependencies. We still need a place for those dependencies. Will we be having some metapackages that do nothing but depend on whatever each set of tests needs? Keep in mind that the set of deps for graphics vs. wireless are very different so it continues to be worthwhile having them separately.

review: Needs Fixing
Revision history for this message
Daniel Manrique (roadmr) wrote :

I'm ready to approve this as soon as the extraneous files (preseed.txt and libvirt.xml) are removed. THanks!

2283. By Brendan Donegan

Remove non-whitelist files

Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks, merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches