Merge lp://staging/~bregma/libgrip/lp-861596 into lp://staging/libgrip

Proposed by Stephen M. Webb
Status: Merged
Merged at revision: 64
Proposed branch: lp://staging/~bregma/libgrip/lp-861596
Merge into: lp://staging/libgrip
Diff against target: 146 lines (+34/-23)
5 files modified
examples/rectangle-mover/Makefile.am (+1/-1)
examples/rectangle-mover/gesture.c (+4/-2)
src/Makefile.am (+13/-12)
src/gripinputdevice.c (+4/-4)
src/gripinputdevice.h (+12/-4)
To merge this branch: bzr merge lp://staging/~bregma/libgrip/lp-861596
Reviewer Review Type Date Requested Status
Chase Douglas (community) Approve
Review via email: mp+79824@code.staging.launchpad.net

Description of the change

(1) Made the generated introspection library have a name that conforms to the GObject introspection runtime requirements (fixes lp:861596).

(2) Renamed the typedef AxisExtents to GripAxisExtents to fix the GObject introspection runtime build failure (this is an API breakage but not an ABI breakage). The API change does not affect eog or evince but may affect unknown third-paty usage.

(3) Turned all g-ir-scanner warnings into errors so the build will break instead of silently producing non-working software.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

Added another commit to reintroduce the AxisExtents symbol, marked it as deprecated, and reverted the API change. Good to go.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

Looks good now that we don't break the API. I assume you meant to name the macro G_IR_IGNORE instead of G_IR_IGNIORE though. I'm approving with that changed to proper english :).

review: Approve
66. By Stephen M. Webb

Re-added AxisExtents symbol, marked it as deprecated, and forced g-ir-scanner to ignore that particular symbol.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches