libgrip

Merge lp://staging/~bregma/libgrip/lp-827958 into lp://staging/libgrip

  1. lp-827958
  2. Merge into trunk
Proposed by Stephen M. Webb
Status: Merged
Merged at revision: 63
Proposed branch: lp://staging/~bregma/libgrip/lp-827958
Merge into: lp://staging/libgrip
Diff against target: 114 lines (+33/-29)
1 file modified
src/gripgesturemanager.c (+33/-29)
To merge this branch: bzr merge lp://staging/~bregma/libgrip/lp-827958
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Sebastien Bacher Pending
Stephen M. Webb Pending
Review via email: mp+78486@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-10-06.

Description of the change

Registers and removes only those widgets whose toplevel was just mapped in the window-mapped callback.

Previously, an attempt to register ALL pending widgets regardless of toplevel was causing an occasional segfault.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote : Posted in a previous version of this proposal

A quick re-review of this fix reveals it introduces another bug.

review: Needs Resubmitting
lp://staging/~bregma/libgrip/lp-827958 updated
65. By Stephen M. Webb

Renamed window_mapped_cb to toplevel_mapped_cb to reduce confusion.

Revision history for this message
Stephen M. Webb (bregma) wrote :

NOTE: made a final commit to change the name of the callback function to reduce future confusion.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

The code looks reasonable to me, but I really don't know gtk well enough to approve it myself, especially given how close we are to release. I am have subscribed Michael Terry and Sebastien Bacher to review since they would know more and have commented in the bug report.

As soon as someone with more gtk knowledge approves, I want to get this path added to libgrip and uploaded. I am off until Tuesday, so please work with Seb, Didier, or someone else as appropriate to get it into Oneiric.

Great work figuring this bug out!

Revision history for this message
Michael Terry (mterry) wrote :

So the code changes themselves looks fine. I haven't tested that it fixes the segfault.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches