Merge lp://staging/~bregma/libgrip/lp-1168370-raring into lp://staging/libgrip/raring

Proposed by Stephen M. Webb
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 77
Merged at revision: 76
Proposed branch: lp://staging/~bregma/libgrip/lp-1168370-raring
Merge into: lp://staging/libgrip/raring
Diff against target: 2144 lines (+702/-1177)
2 files modified
src/gripgesturemanager.c (+671/-1154)
src/gripinputdevice.c (+31/-23)
To merge this branch: bzr merge lp://staging/~bregma/libgrip/lp-1168370-raring
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+163448@code.staging.launchpad.net

Commit message

Moved to GEISv2 to fix an unfortunate lack of events (lp: #1168370).

Description of the change

Cherry-picked critical bug fix from trunk for SRU into 13.04.

Original description of change on trunk:

Rewrote libgrip to use GEISv2 instead of GEISv1 because libgrip's assumptions about device tracking across instances was invalid, and GEISv1 is deprecated.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:76
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~bregma/libgrip/lp-1168370-raring/+merge/163448/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/libgrip-raring-ci/1/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libgrip-raring-raring-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libgrip-raring-raring-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libgrip-raring-raring-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libgrip-raring-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

77 + g_list_foreach(priv->classes, (GFunc) g_free, NULL);

why not g_list_free_full(priv->classes, g_free) instead?

77. By Stephen M. Webb

Used g_list_free_full() to free a GList

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: