Merge lp://staging/~bregma/evemu/lp-731678 into lp://staging/evemu
Proposed by
Stephen M. Webb
| Status: | Merged |
|---|---|
| Merged at revision: | 44 |
| Proposed branch: | lp://staging/~bregma/evemu/lp-731678 |
| Merge into: | lp://staging/evemu |
| Diff against target: |
1466 lines (+1291/-5) 23 files modified
.bzrignore (+1/-0) Makefile.am (+5/-1) configure.ac (+2/-0) data/3m.prop (+1/-1) data/bcm5974.prop (+1/-1) data/ntrig-dell-xt2.event (+146/-0) data/ntrig-dell-xt2.prop (+31/-0) data/ntrig-lenovo-T410s.prop (+24/-0) data/synaptics.prop (+32/-0) data/wetab.prop (+1/-1) python/Makefile.am (+37/-0) python/evemu-test-runner.in (+4/-0) python/evemu/__init__.py (+271/-0) python/evemu/base.py (+43/-0) python/evemu/const.py (+235/-0) python/evemu/exception.py (+22/-0) python/evemu/testing/mocker.py (+5/-0) python/evemu/testing/result.py (+48/-0) python/evemu/testing/runner.py (+63/-0) python/evemu/testing/testcase.py (+70/-0) python/evemu/tests/test_base.py (+25/-0) python/evemu/tests/test_device.py (+223/-0) src/evemu.c (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~bregma/evemu/lp-731678 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Open Input Framework Team | Pending | ||
|
Review via email:
|
|||
Description of the change
This MR takes Duncan McGreggor's original Python bindings branch, fixes all the unit tests, and refactors into a single Device class with a clear invariant and a simpler API. A few bits of the original remain.
The unit tests exercise pretty much all of the C API, so that takes care of unit testing for this library.
The unit tests need to be run as root because they require write access to kernel devices. They may also exercise race condition bugs in desktop software (eg. utouch-geis, GTK+, x.org) and may randomly require you to restart all or part of your system. Bugs have been filed upstream in those projects. Do not say you have not been warned.
To post a comment you must log in.
Revision history for this message
| Chase Douglas (chasedouglas) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Everything looks sane to me, though I don't know python very well. I'm fine with merging it anyways though. Unit testing is good, creating new bindings is better, and unit testing through the new bindings is awesome :).
The only question I have is whether the python/