Merge lp://staging/~bratsche/oif/evince-drag-selection into lp://staging/~oif-team/oif/evince-gestures-trunk
Proposed by
Cody Russell
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~bratsche/oif/evince-drag-selection |
Merge into: | lp://staging/~oif-team/oif/evince-gestures-trunk |
Diff against target: |
345 lines (+203/-24) 3 files modified
libview/ev-view.c (+131/-9) libview/ev-view.h (+11/-0) shell/ev-window.c (+61/-15) |
To merge this branch: | bzr merge lp://staging/~bratsche/oif/evince-drag-selection |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Duncan McGreggor (community) | Needs Fixing | ||
Review via email: mp+42545@code.staging.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 4213. By Cody Russell
-
Remove unused commented code.
- 4212. By Cody Russell
-
Selection clearing on tap.
- 4211. By Cody Russell
-
Tap-and-drag selection
I think that boulabiar mentioned this in another review, but the drag goes the wrong way for touch screen -- dragging left pans the substrate right, and vice versa.
Also, I noted that during pinch, one can't move the substrate, so we didn't get that for free. I'll update the related ticket.