grope

Merge lp://staging/~bratsche/libgrope/gobject-introspection into lp://staging/libgrope

gobject-introspection
Merge into trunk

Proposed by Cody Russell on 2010-11-10

Status:	Merged
Merged at revision:	6
Proposed branch:	lp://staging/~bratsche/libgrope/gobject-introspection
Merge into:	lp://staging/libgrope
Diff against target:	234 lines (+149/-4) 6 files modified Makefile.am (+1/-1) configure.ac (+3/-1) m4/introspection.m4 (+88/-0) src/Makefile.am (+43/-2) src/gropegesturemanager.c (+2/-0) src/gropegesturemanager.h (+12/-0)
To merge this branch:	bzr merge lp://staging/~bratsche/libgrope/gobject-introspection
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Duncan McGreggor (community)		2010-11-10	Approve on 2010-11-10
Review via email: mp+40575@code.staging.launchpad.net

lp://staging/~bratsche/libgrope/gobject-introspection updated on 2010-11-10

7. By Cody Russell on 2010-11-10: Remove some unnecessary indentation
8. By Cody Russell on 2010-11-10: Add missing introspection.m4 file

Revision history for this message

Duncan McGreggor (oubiwann) wrote on 2010-11-10:

1) PACKAGE_BUGREPORT = https://bugs.launchpad.net/avani should probably point to https://bugs.launchpad.net/libgrope instead

2) In the README, you should add a section for building the Python bindings. The dependencies should be listed (e.g., I was missing "sudo apt-get install gobject-introspection", "sudo apt-get install libgirepository1.0-dev", and "sudo apt-get install gir1.0-gtk-2.0).

Revision history for this message

Cody Russell (bratsche) wrote on 2010-11-10:

1) Fixed and pushed.

2) I don't think so, because this is kind of an upstream package so we shouldn't include Ubuntu-specific package names in the README. Instead this should just be sorted out when we create packaging for this project, and then it's easily solved by doing "apt-get build-dep libgrope" or whatever.

lp://staging/~bratsche/libgrope/gobject-introspection updated on 2010-11-10