Merge lp://staging/~brandontschaefer/unity/ubus-race-overlay-for-panel into lp://staging/unity
Status: | Rejected |
---|---|
Rejected by: | Brandon Schaefer |
Proposed branch: | lp://staging/~brandontschaefer/unity/ubus-race-overlay-for-panel |
Merge into: | lp://staging/unity |
Diff against target: |
93 lines (+20/-23) 4 files modified
dash/DashController.cpp (+4/-9) launcher/LauncherController.cpp (+1/-1) manual-tests/Dash.txt (+15/-0) plugins/unityshell/src/unityshell.cpp (+0/-13) |
To merge this branch: | bzr merge lp://staging/~brandontschaefer/unity/ubus-race-overlay-for-panel |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Azzarone (community) | Needs Information | ||
Tim Penhey (community) | Approve | ||
Review via email: mp+122786@code.staging.launchpad.net |
Commit message
Fixes UBus races condition with Dash opening then closing very fast. As well as the Launcher getting X focus over the Dash.
Description of the change
=== Problem ===
When opening then closing the Dash quickly the Ubus message the panel listens on was sent into a race condition.
=== Fix ===
The problem was from using an Idle while sending OVERLAY SHOWN, which didn't fix the real issue. The real issue is the laucher gets X focus when the Dash is open. This should not happen.
=== Test ===
Manual test
Unmerged revisions
- 2658. By Brandon Schaefer
-
* forgot to remove comment
- 2657. By Brandon Schaefer
-
* Fixed the real issue with the launcher stealing X focus from the dash
- 2656. By Brandon Schaefer
-
* Fixes race condition where the panel would recive a OVERLAY HIDDEN before the OVERLAY OPENED
The Jenkins job https:/ /jenkins. qa.ubuntu. com/job/ automerge- unity/1214/ console reported an error when processing this lp:~brandontschaefer/unity/ubus-race-overlay-for-panel branch.
Not merging it.