Merge lp://staging/~brandontschaefer/unity/opening-dash-in-scale-mode-SRU into lp://staging/unity/5.0
Proposed by
Brandon Schaefer
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Brandon Schaefer | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 2375 | ||||
| Proposed branch: | lp://staging/~brandontschaefer/unity/opening-dash-in-scale-mode-SRU | ||||
| Merge into: | lp://staging/unity/5.0 | ||||
| Diff against target: |
135 lines (+55/-2) 4 files modified
plugins/unityshell/src/DashController.cpp (+5/-2) plugins/unityshell/src/unityshell.cpp (+24/-0) plugins/unityshell/src/unityshell.h (+2/-0) tests/autopilot/autopilot/tests/test_dash.py (+24/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~brandontschaefer/unity/opening-dash-in-scale-mode-SRU | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomi Richards (community) | quality | Approve | |
|
Review via email:
|
|||
Commit message
The dash will now open when invoked while in spread/scale mode.
Description of the change
=== Problem ===
When is spread/scale mode you could not activate the dash.
=== Fix ===
Well this was a bit of a hack, as the scale plugin consumes all input, expect for the hacks already in place in unity. So to open the home dash I had to assume while in scale mode that the state CompTermTapped was true to tests for a super key tapping...if that was true then assume was_tap is true so the dash will open. (Otherwise it wont)
=== Tests ===
There are ap test for opening the Home lens/ Command lens/ Other lenses (app,file,music all open the same way)
To post a comment you must log in.
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) | # |
review:
Approve
(quality)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
