Unity

Merge lp://staging/~brandontschaefer/unity/lp.966030-fix into lp://staging/unity

lp.966030-fix
Merge into trunk

Proposed by Brandon Schaefer on 2013-06-18

Status:

Merged

Approved by:

Marco Trevisan (Treviño) on 2013-06-21

Approved revision:

no longer in the source branch.

Merged at revision:

3380

Proposed branch:

lp://staging/~brandontschaefer/unity/lp.966030-fix

Merge into:

lp://staging/unity

Diff against target:

143 lines (+50/-3)

3 files modified

plugins/unityshell/src/unityshell.cpp (+24/-3)
unity-shared/PluginAdapter.cpp (+24/-0)
unity-shared/PluginAdapter.h (+2/-0)

To merge this branch:

bzr merge lp://staging/~brandontschaefer/unity/lp.966030-fix

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Marco Trevisan (Treviño)		2013-06-18	Approve on 2013-06-21
PS Jenkins bot (community)	continuous-integration		Approve on 2013-06-20
Review via email: mp+170180@code.staging.launchpad.net

Commit message

Show desktop now only works for individual workspaces. Also if any new windows are opened, or one is restored on that workspace then the next Show desktop will minimize those. The only time windows are restored are when no new windows have been mapped, and no windows have been restored for that workspace only.

Description of the change

Changes to the show desktop icon:

- Only minimizes windows on current workspace.
- Will only restore windows if and only if:
  -- No new windows have been mapped (opened).
  -- No new windows have been unminimized.
  -- The user has not moved workspaces.
- When we are restoring windows from Show desktop, all of them are unminimzed on all workspaces.

Testing this might be hard, but im looking into it :).

Video does not show the new restore fix, but still good to show what it does now.
Video: http://ubuntuone.com/2G483y5nLc0OBkhHWww1gm

So overall things to manually test:
- Only windows in current workspace get minimized.
- Windows on the same workspace only get restored IFF, no new windows have been opened,
no windows have been restore from that workspace.
- All windows must be restored if returning to a workspace that is empty.
- If any new window, or a window is restore, then the next time a ShowDesktop is activated for that workspace all the windows are minimized (for that workspace only).