Unity

Merge lp://staging/~brandontschaefer/unity/launcher-drag-window-slow-animation into lp://staging/unity

launcher-drag-window-slow-animation
Merge into trunk

Proposed by Brandon Schaefer on 2012-09-13

Status:

Merged

Approved by:

Nick Dedekind on 2012-09-19

Approved revision:

no longer in the source branch.

Merged at revision:

2717

Proposed branch:

lp://staging/~brandontschaefer/unity/launcher-drag-window-slow-animation

Merge into:

lp://staging/unity

Diff against target:

125 lines (+30/-8)

4 files modified

launcher/Launcher.cpp (+2/-2)
launcher/LauncherDragWindow.cpp (+22/-3)
launcher/LauncherDragWindow.h (+5/-2)
launcher/SoftwareCenterLauncherIcon.cpp (+1/-1)

To merge this branch:

bzr merge lp://staging/~brandontschaefer/unity/launcher-drag-window-slow-animation

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
John Lea (community)	design	2012-09-13	Approve on 2012-09-18
Nick Dedekind (community)		2012-09-13	Approve on 2012-09-18
Review via email: mp+124086@code.staging.launchpad.net

Commit message

Slows the animation down when installing applications in the Dash Preview and the Software Center.

Description of the change

=== Problem ===
When installing applications the animation is fast.

=== Fix ===
Add a function that will do a slow animation to the LauncherDragWindow...This will slow the animation down for the applications installed through the Dash Previews AND the Software Center...if the Software Center animation should not change then this will require a little bit more work.

The current speed: http://ubuntuone.com/0fNMlHKnBWxqkdh5m2sAeJ

The new speed: http://ubuntuone.com/72QLokRsyhVmRL8bvl2Cvz

lp://staging/~brandontschaefer/unity/launcher-drag-window-slow-animation updated on 2012-09-14

2685. By Michal Hruby on 2012-09-14: Disable the flow renderer. Fixes: https://bugs.launchpad.net/bugs/1049593. Approved by Andrea Azzarone, John Lea.
2686. By Paweł Stołowski on 2012-09-14: Added two new special icons for missing album cover; to be used by music lens. They don't really fit into unity-asset-pool as they don't have regular sizes.. Fixes: https://bugs.launchpad.net/bugs/1049217. Approved by Michal Hruby.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2012-09-14:

I'm wondering if the current speed is caused by the start position called, since this happens when the icon has to travel a lot...
I've done some work on this area on lp:~3v1n0/unity/launcher-draggable-icons/+merge/123311 could you check how this work with it?

lp://staging/~brandontschaefer/unity/launcher-drag-window-slow-animation updated on 2012-09-14

2687. By Nick Dedekind on 2012-09-14: Updated dash result highlight focus to 106x106 pixels with 20% white opacity. Increased dash result file image size to 96x96.. Fixes: https://bugs.launchpad.net/bugs/1049128. Approved by John Lea, Michal Hruby.
2688. By Michal Hruby on 2012-09-14: Avoid construction of row wrappers. Fixes: https://bugs.launchpad.net/bugs/1050342. Approved by Gord Allott.
2689. By Nick Dedekind on 2012-09-14: Added extra-text to preview actions (for price tags).. Fixes: . Approved by Michal Hruby.
2690. By Michal Hruby on 2012-09-14: Change the IconLoader methods to allow specifying both maximum width and height. Updated rendering of the icon ribbons.. Fixes: . Approved by Omer Akram, John Lea, Nick Dedekind.
2691. By Nick Dedekind on 2012-09-14: Preview navigation buttons opacity changes on mouse-over.. Fixes: . Approved by Michal Hruby, John Lea.
2692. By Gord Allott on 2012-09-14: Adds a new background gradient to the dash and panel, as well as removes some separator lines. Fixes: https://bugs.launchpad.net/bugs/1049593. Approved by Omer Akram, Andrea Azzarone, John Lea.
2693. By Gord Allott on 2012-09-14: some changes in spacing from new designs. Fixes: . Approved by Gord Allott.

Revision history for this message

Brandon Schaefer (brandontschaefer) wrote on 2012-09-14:

Yes it does slow down the closer it gets to its target bbut each timeout it gets 30% closer to its target until the change in y and x gets abs(delta) < 5. So that is a bit fast, my branch takes that and makes it only move 5% closer to its target each timeout. Sooo it seems to make it slower we adjust the % of how close you move it to the target each time.

With your new branch you do change somethings around, but the Dash Preview still sends a dbus message to the LauncherController::OnLauncherAddRequestSpecial...which ends up making a SoftwareCenterIcon, which then uses its animation. So this should still be fine :)

lp://staging/~brandontschaefer/unity/launcher-drag-window-slow-animation updated on 2012-09-18

2694. By Tim Penhey on 2012-09-14: Fixed a warning emitted by unreferencing an object owned by a smart pointer in HudController.cpp. Caused by adopting a new nux::BaseWindow.. Fixes: . Approved by Brandon Schaefer.
2695. By Nick Dedekind on 2012-09-14: Removed dash preview background shadow.. Fixes: . Approved by Brandon Schaefer.
2696. By Andrea Azzarone on 2012-09-15: Raise shortcut overlay on show.. Fixes: https://bugs.launchpad.net/bugs/985883. Approved by Brandon Schaefer.
2697. By Andrea Azzarone on 2012-09-16: Reduce internal-padding inside filter buttons.. Fixes: https://bugs.launchpad.net/bugs/856277. Approved by Brandon Schaefer.
2698. By Daniel van Vugt on 2012-09-17: Restore the panel shadow, which has been missing since Unity 6.4.
(LP: #1045705). Fixes: https://bugs.launchpad.net/bugs/1045705. Approved by Omer Akram, Marco Trevisan (Treviño).
2699. By Paweł Stołowski on 2012-09-17: Register file delete events in zeitgeist when file is dropped onto Trash launcher icon.
Added zeitgeist dependency.. Fixes: https://bugs.launchpad.net/bugs/870150. Approved by Marco Trevisan (Treviño), Michal Hruby.
2700. By Omer Akram on 2012-09-17: write AP test for bug 1045752. Fixes: . Approved by Neil J. Patel.
2701. By Nicolas d'Offay on 2012-09-17: Added left and right click exit to cover art for all previews.. Fixes: https://bugs.launchpad.net/bugs/1045230, https://bugs.launchpad.net/bugs/1045752. Approved by .
2702. By Andrea Azzarone on 2012-09-17: Show the alt-tab on the monitor with the mouse.. Fixes: https://bugs.launchpad.net/bugs/1044293. Approved by Marco Trevisan (Treviño).
2703. By Thomi Richards on 2012-09-17: Fix several failing autopilot tests.. Fixes: . Approved by Brandon Schaefer.
2704. By Ken VanDine on 2012-09-18: Added SocialPreview. Fixes: https://bugs.launchpad.net/bugs/1049127. Approved by Neil J. Patel.
2705. By Tim Penhey on 2012-09-18: Fix the standalone launcher crash on exit.. Fixes: . Approved by Brandon Schaefer.
2706. By Tim Penhey on 2012-09-18: Fix uninitialized and invalid reads as reported by valgrind.. Fixes: . Approved by Brandon Schaefer.
2707. By Daniel van Vugt on 2012-09-18: This branch fixes several failing autopilot tests.. Fixes: . Approved by Omer Akram, Christopher Lee.
2708. By Nick Dedekind on 2012-09-18: Enabled focus navigation for dash preview buttons.. Fixes: https://bugs.launchpad.net/bugs/1045416. Approved by Michal Hruby, John Lea.
2709. By Nick Dedekind on 2012-09-18: Fixed scrolling in music preview.. Fixes: . Approved by Neil J. Patel.

Revision history for this message

Nick Dedekind (nick-dedekind) wrote on 2012-09-18:

Can you define slow/fast speeds at the top of class?

Otherwise LGTM.

review: Approve

Revision history for this message

John Lea (johnlea) on 2012-09-18:

review: Approve (design)

lp://staging/~brandontschaefer/unity/launcher-drag-window-slow-animation updated on 2012-09-19

2710. By Neil J. Patel on 2012-09-18: Send the current XLib timestamp to applications when we're opening them to not confuse them and cause issues like what we have seen with Firefox (bug linked).. Fixes: https://bugs.launchpad.net/bugs/1050687. Approved by Marco Trevisan (Treviño).
2711. By Neil J. Patel on 2012-09-18: Implemented the loading of the category icon for the application category (required for the apps lens).. Fixes: https://bugs.launchpad.net/bugs/1049593. Approved by Marco Trevisan (Treviño).
2712. By Andrea Azzarone on 2012-09-18: Refactor unity::Settings to use nux::RWProperty.. Fixes: https://bugs.launchpad.net/bugs/1044681. Approved by Omer Akram.
2713. By Marco Trevisan (Treviño) on 2012-09-18: LauncherController, FavoriteStore, Launcher, Icons: always use sort priority based on favorites to get positioned on launcher. Fixes: https://bugs.launchpad.net/bugs/761155, https://bugs.launchpad.net/bugs/858540, https://bugs.launchpad.net/bugs/868423, https://bugs.launchpad.net/bugs/1028927, https://bugs.launchpad.net/bugs/1042845, https://bugs.launchpad.net/bugs/1045146. Approved by Andrea Azzarone, Brandon Schaefer.
2714. By Marco Trevisan (Treviño) on 2012-09-19: UnityWindow: implements sigc::trackable. Fixes: https://bugs.launchpad.net/bugs/1052683. Approved by Brandon Schaefer.
2715. By Nick Dedekind on 2012-09-19: Dash/Hud no longer steal mouse events outside their content area. Better draw handling of hud animation.. Fixes: https://bugs.launchpad.net/bugs/857422, https://bugs.launchpad.net/bugs/1049593. Approved by Brandon Schaefer.
2716. By Didier Roche-Tolomelli on 2012-09-19: add a depreacated --reset option as it seems otherwise to match to --reset-icons.. Fixes: . Approved by Brandon Schaefer.
2717. By Brandon Schaefer on 2012-09-19: Slows the animation down when installing applications in the Dash Preview and the Software Center.. Fixes: https://bugs.launchpad.net/bugs/1045746. Approved by John Lea, Nick Dedekind.