Merge lp://staging/~brandontschaefer/unity/drag-icon-launcher-close-dash-fix into lp://staging/unity
Proposed by
Brandon Schaefer
| Status: | Merged |
|---|---|
| Approved by: | Thomi Richards |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2433 |
| Proposed branch: | lp://staging/~brandontschaefer/unity/drag-icon-launcher-close-dash-fix |
| Merge into: | lp://staging/unity |
| Diff against target: |
89 lines (+23/-6) 2 files modified
launcher/Launcher.cpp (+5/-2) manual-tests/Dash.txt (+18/-4) |
| To merge this branch: | bzr merge lp://staging/~brandontschaefer/unity/drag-icon-launcher-close-dash-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomi Richards (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Documents and files now dragged from the Dash to the Launcher into an application will close the dash.
Description of the change
=== Problem ===
When dragging files from the Dash to an application in the Launcher the Dash would remain open.
=== Fix ===
If a drag drop is being processed and getting sent to a _dnd_hovered_icon and the Dash is open close the dash.
=== Test ===
Manual test added.
To post a comment you must log in.
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Approved, although we need more information about how we can test the file lens. Ideally we'd be able to make sure the file lens is showing a particular file, at which point we can write an autopilot test for this.