Merge lp://staging/~brandontschaefer/unity/drag-file-dash-to-launcher-close-SRU into lp://staging/unity/5.0

Proposed by Brandon Schaefer
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 2368
Proposed branch: lp://staging/~brandontschaefer/unity/drag-file-dash-to-launcher-close-SRU
Merge into: lp://staging/unity/5.0
Diff against target: 60 lines (+19/-3)
2 files modified
manual-tests/Dash.txt (+14/-1)
plugins/unityshell/src/Launcher.cpp (+5/-2)
To merge this branch: bzr merge lp://staging/~brandontschaefer/unity/drag-file-dash-to-launcher-close-SRU
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+111460@code.staging.launchpad.net

Commit message

Documents and files now dragged from the Dash to the Launcher into an application will close the dash.

Description of the change

=== Problem ===
When dragging files from the Dash to an application in the Launcher the Dash would remain open.

=== Fix ===
If a drag drop is being processed and getting sent to a _dnd_hovered_icon and the Dash is open close the dash.

=== Test ===
Manual test added.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

LGTM

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: