overlay-scrollbar

Merge lp://staging/~brandontschaefer/overlay-scrollbar/lp.907837-fix into lp://staging/overlay-scrollbar

  1. lp.907837-fix
  2. Merge into trunk
Proposed by Brandon Schaefer
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 380
Merged at revision: 379
Proposed branch: lp://staging/~brandontschaefer/overlay-scrollbar/lp.907837-fix
Merge into: lp://staging/overlay-scrollbar
Diff against target: 129 lines (+65/-34)
1 file modified
os/os-scrollbar.c (+65/-34)
To merge this branch: bzr merge lp://staging/~brandontschaefer/overlay-scrollbar/lp.907837-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Andrea Azzarone (community) Approve
Review via email: mp+181637@code.staging.launchpad.net

Commit message

Remove the check if a GtkPaned is H/VPaned, as its deprecated in gtk 3.0. Now just use the priv->side to tell if which way its facing. If its true on the side, then allow paned to be resized.

Description of the change

Gtk VPaned/HPaned is deprecated in 3.0. So instead of asserting if its HPANED/VPANED just switch on the side of the pane and figure out if its resizable or not. If so, make it so!

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:379
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/40/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins:8080/job/overlay-scrollbar-ci/8/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:380
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/9/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/41/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-armhf-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/overlay-scrollbar-ci/9/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Approved! :D

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/42/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-amd64-autolanding/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-armhf-autolanding/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-i386-autolanding/3

review: Needs Fixing (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Apologies for this; a Jenkins kink has been remedied.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-amd64-autolanding/4
    FAILURE: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-armhf-autolanding/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-saucy-i386-autolanding/4
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/44/artifact/results/coverity/NO_COVERITY_DEFECTS.txt

review: Needs Fixing (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

One more time!

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches