overlay-scrollbar

Merge lp://staging/~brandontschaefer/overlay-scrollbar/lp.1109115-CID-13650 into lp://staging/overlay-scrollbar

  1. lp.1109115-CID-13650
  2. Merge into trunk
Proposed by Brandon Schaefer
Status: Merged
Approved by: Allan LeSage
Approved revision: 365
Merged at revision: 365
Proposed branch: lp://staging/~brandontschaefer/overlay-scrollbar/lp.1109115-CID-13650
Merge into: lp://staging/overlay-scrollbar
Diff against target: 23 lines (+0/-2)
2 files modified
os/os-scrollbar.c (+0/-1)
os/os-thumb.c (+0/-1)
To merge this branch: bzr merge lp://staging/~brandontschaefer/overlay-scrollbar/lp.1109115-CID-13650
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Allan LeSage (community) Approve
Review via email: mp+146249@code.staging.launchpad.net

Commit message

Fixes CID-13650, default case should never be able to be reached.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:365
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/15/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/15/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/./build=pbuilder,distribution=raring,flavor=armhf/15/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/./build=pbuilder,distribution=raring,flavor=i386/15/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/15//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/./build=pbuilder,distribution=raring,flavor=armhf/15//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/./build=pbuilder,distribution=raring,flavor=i386/15//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/15//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Brandon and I discussed, I'm going to approve and push!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=coverity-raring,flavor=amd64/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=raring,flavor=armhf/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=raring,flavor=i386/7/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=coverity-raring,flavor=amd64/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=raring,flavor=armhf/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=raring,flavor=i386/8/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad (maybe a permission problem?).
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=coverity-raring,flavor=amd64/9/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=raring,flavor=armhf/9/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=raring,flavor=i386/9/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=coverity-raring,flavor=amd64/9//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=raring,flavor=armhf/9//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-autolanding/./build=pbuilder,distribution=raring,flavor=i386/9//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

review: Needs Fixing (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Configuration error in the Jenkins job, should be corrected, approving again. . . .

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches