overlay-scrollbar

Merge lp://staging/~brandontschaefer/overlay-scrollbar/hidpi-support into lp://staging/overlay-scrollbar

  1. hidpi-support
  2. Merge into trunk
Proposed by Brandon Schaefer
Status: Approved
Approved by: Christopher Townsend
Approved revision: 388
Proposed branch: lp://staging/~brandontschaefer/overlay-scrollbar/hidpi-support
Merge into: lp://staging/overlay-scrollbar
Diff against target: 503 lines (+294/-33)
6 files modified
os/Makefile.am (+2/-0)
os/em-converter.c (+153/-0)
os/em-converter.h (+43/-0)
os/os-private.h (+14/-10)
os/os-scrollbar.c (+51/-21)
os/os-thumb.c (+31/-2)
To merge this branch: bzr merge lp://staging/~brandontschaefer/overlay-scrollbar/hidpi-support
Reviewer Review Type Date Requested Status
Christopher Townsend (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+214283@code.staging.launchpad.net

Commit message

Scale up the overlay-scrollbars correctly when the DPI changes. Does not work very nice when the gtk-scaling-factor is changed.

Description of the change

Scale up the overlay-scrollbars correctly when the DPI changes. Does not work very nice when the gtk-scaling-factor is changed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:387
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/14/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-armhf-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/overlay-scrollbar-ci/14/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Christopher Townsend (townsend) wrote :

Seems to work fine for < 2. That's good enough for now.

review: Approve
Reply
Revision history for this message
Christopher Townsend (townsend) wrote :

Ok, update looks fine as well.

review: Approve
Reply
lp://staging/~brandontschaefer/overlay-scrollbar/hidpi-support updated
389. By Brandon Schaefer

* Fix problem if a newly mapped monitor is plugged in and left
  to the default scale value.

Unmerged revisions

389. By Brandon Schaefer

* Fix problem if a newly mapped monitor is plugged in and left
  to the default scale value.

388. By Brandon Schaefer

* Increase the prox check by the DPI!

387. By Brandon Schaefer

* Move the setting the device scale code, becuase if we are not on gtk3 we crash!
* Fix the grip not being drawn when divison of the w/h changed the w/h to be off by 1

386. By Brandon Schaefer

* Dynamically update the scrollbar gtk allocation if we change
  monitors. (Only when are attempting to use the scrollbar do we check)

385. By Brandon Schaefer

* Set the monitor when it changes. Need to find a good way to tell gtk to re-do
  gtk allocation.

384. By Brandon Schaefer

* Add HiDPI Support for the overlay scrollbars

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches