Nux

Merge lp://staging/~brandontschaefer/nux/lp.834465-fix-ABI-BREAK into lp://staging/nux

  1. lp.834465-fix-ABI-BREAK
  2. Merge into trunk
Proposed by Brandon Schaefer
Status: Needs review
Proposed branch: lp://staging/~brandontschaefer/nux/lp.834465-fix-ABI-BREAK
Merge into: lp://staging/nux
Diff against target: 62 lines (+19/-1)
2 files modified
Nux/TextEntry.cpp (+14/-1)
Nux/TextEntry.h (+5/-0)
To merge this branch: bzr merge lp://staging/~brandontschaefer/nux/lp.834465-fix-ABI-BREAK
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Stephen M. Webb (community) Needs Fixing
Review via email: mp+258321@code.staging.launchpad.net

Commit message

Allow setting the cursor blink speed

Description of the change

Allow setting the cursor blink speed

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:859
http://jenkins.qa.ubuntu.com/job/nux-ci/118/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-vivid-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-vivid-armhf-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-vivid-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/nux-ci/118/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good, and one minor thing if you want.
Also check this comment https://code.launchpad.net/~brandontschaefer/unity/lp.834465-fix-ABI-BREAK-FIX/+merge/258323/comments/645079 in order to adapt the API to support no-blinking.

By the way I'd like to follow this ABI break branch with another change for having consistent double clicks settings as well (so we can just break things once).

Reply
Revision history for this message
Stephen M. Webb (bregma) wrote :

Could you please break the ABI bump into a separate MP so we can batch multiple ABI-breaking changes together (but still be able to back one out if necessary)?

review: Needs Fixing
Reply
lp://staging/~brandontschaefer/nux/lp.834465-fix-ABI-BREAK updated
860. By Brandon Schaefer

* Remove the ABI bump, THIS BRANCH STILL BREAKS ABI. Just need to bump the ABI
  in a different branch

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:860
http://jenkins.qa.ubuntu.com/job/nux-ci/120/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/nux-wily-amd64-ci/2/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-wily-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-wily-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/nux-ci/120/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:860
http://jenkins.qa.ubuntu.com/job/nux-ci/121/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/nux-wily-amd64-ci/3/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-wily-armhf-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-wily-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/nux-ci/121/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

860. By Brandon Schaefer

* Remove the ABI bump, THIS BRANCH STILL BREAKS ABI. Just need to bump the ABI
  in a different branch

859. By Brandon Schaefer

* Allows setting the cursor blink speed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches