Mir

Merge lp://staging/~brandontschaefer/mir/improve-capnproto-cmake-find into lp://staging/mir

  1. improve-capnproto-cmake-find
  2. Merge into development-branch
Proposed by Brandon Schaefer
Status: Rejected
Rejected by: Brandon Schaefer
Proposed branch: lp://staging/~brandontschaefer/mir/improve-capnproto-cmake-find
Merge into: lp://staging/mir
Diff against target: 17 lines (+7/-1)
1 file modified
src/capnproto/CMakeLists.txt (+7/-1)
To merge this branch: bzr merge lp://staging/~brandontschaefer/mir/improve-capnproto-cmake-find
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Needs Fixing
Alan Griffiths Approve
Chris Halse Rogers Approve
Review via email: mp+331565@code.staging.launchpad.net

Commit message

Capnproto upstream uses a different cmake find file then 0.5.3 in universe now. Get ready for that change when ever it hits.

Description of the change

Capnproto upstream uses a different cmake find file then 0.5.3 in universe now. Get ready for that change when ever it hits.

To post a comment you must log in.
Revision history for this message
Chris Halse Rogers (raof) wrote :

Sure.

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

/sigh

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Xenial bites!

15:42:37 CMake Error at src/capnproto/CMakeLists.txt:25 (if):
15:42:37 if given arguments:
15:42:37
15:42:37 "@CAPNP_VERSION@" "GREATER_EQUAL" "0.6.1"
15:42:37
15:42:37 Unknown arguments specified

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:4276
https://mir-jenkins.ubuntu.com/job/mir-ci/3707/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/5081/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/5319
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/5308
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/5308
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/5308
    ABORTED: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5127/console
    ABORTED: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/5127/console
    ABORTED: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5127/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/5127/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3707/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://mir-jenkins.ubuntu.com/job/mir-autolanding/1447/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/5085/console
    None: https://mir-jenkins.ubuntu.com/job/generic-land-mp/1582/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/5323
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/5311
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/5311
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/5311

review: Needs Fixing (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Right wont work on xenial. Meh this isnt needed until 0.6.1 is pushed. Rejected until we need this again.

Unmerged revisions

4276. By Brandon Schaefer

* Capnproto upstream uses a different cmake file then universe. Get ready for this change

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches