Juju Charms Collection
quantum-gateway package

Merge lp://staging/~brad-marshall/charms/trusty/quantum-gateway/add-nrpe-checks into lp://staging/charms/trusty/quantum-gateway

  1. Trusty Tahr (14.04)
  2. add-nrpe-checks
  3. Merge into trunk
Proposed by Brad Marshall
Status: Merged
Merged at revision: 81
Proposed branch: lp://staging/~brad-marshall/charms/trusty/quantum-gateway/add-nrpe-checks
Merge into: lp://staging/charms/trusty/quantum-gateway
Diff against target: 568 lines (+468/-0)
7 files modified
charm-helpers-hooks.yaml (+1/-0)
config.yaml (+10/-0)
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+222/-0)
hooks/charmhelpers/contrib/charmsupport/volumes.py (+156/-0)
hooks/quantum_hooks.py (+68/-0)
hooks/quantum_utils.py (+8/-0)
metadata.yaml (+3/-0)
To merge this branch: bzr merge lp://staging/~brad-marshall/charms/trusty/quantum-gateway/add-nrpe-checks
Reviewer Review Type Date Requested Status
Liam Young (community) Disapprove
Review via email: mp+241486@code.staging.launchpad.net

Description of the change

Adds nrpe-external-master interface and adds basic nrpe checks.

To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #994 trusty-quantum-gateway for brad-marshall mp241486
    LINT FAIL: lint-test failed

LINT Results (max last 5 lines):
ERROR:root:Make target returned non-zero.
  hooks/quantum_hooks.py:205:80: E501 line too long (92 > 79 characters)
  hooks/quantum_hooks.py:236:22: E251 unexpected spaces around keyword / parameter equals
  hooks/quantum_hooks.py:236:24: E251 unexpected spaces around keyword / parameter equals
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/8955761/
Build: http://10.98.191.181:8080/job/charm_lint_check/994/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #829 trusty-quantum-gateway for brad-marshall mp241486
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/quantum_utils 199 1 99% 354
  TOTAL 442 31 93%
  Ran 82 tests in 3.414s
  FAILED (errors=3)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/8955779/
Build: http://10.98.191.181:8080/job/charm_unit_test/829/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_amulet_test #374 trusty-quantum-gateway for brad-marshall mp241486
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv05"
  WARNING cannot delete security group "juju-osci-sv05-0". Used by another environment?
  juju-test INFO : Results: 1 passed, 2 failed, 0 errored
  ERROR subprocess encountered error code 2
  make: *** [test] Error 2

Full amulet test output: http://paste.ubuntu.com/8955979/
Build: http://10.98.191.181:8080/job/charm_amulet_test/374/

lp://staging/~brad-marshall/charms/trusty/quantum-gateway/add-nrpe-checks updated
79. By Brad Marshall

[bradm] Added sysvinit daemon monitoring, use services() instead of hard coded daemon list, pep8 fixes

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1085 trusty-quantum-gateway for brad-marshall mp241486
    LINT FAIL: lint-test failed

LINT Results (max last 5 lines):
INFO:root:Searching for: ['@flake8']
INFO:root:command: make -f Makefile lint
ERROR:root:Make target returned non-zero.
  hooks/quantum_utils.py:501:1: F811 redefinition of unused 'services' from line 405
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/9052126/
Build: http://10.98.191.181:8080/job/charm_lint_check/1085/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #919 trusty-quantum-gateway for brad-marshall mp241486
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/quantum_utils 204 5 98% 354, 407-410
  TOTAL 459 47 90%
  Ran 82 tests in 3.445s
  FAILED (errors=3)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/9052128/
Build: http://10.98.191.181:8080/job/charm_unit_test/919/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #427 trusty-quantum-gateway for brad-marshall mp241486
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv05"
  WARNING cannot delete security group "juju-osci-sv05-0". Used by another environment?
  juju-test INFO : Results: 1 passed, 2 failed, 0 errored
  ERROR subprocess encountered error code 2
  make: *** [test] Error 2

Full amulet test output: http://paste.ubuntu.com/9052219/
Build: http://10.98.191.181:8080/job/charm_amulet_test/427/

lp://staging/~brad-marshall/charms/trusty/quantum-gateway/add-nrpe-checks updated
80. By Brad Marshall

[bradm] Removed puppet header from nagios_plugin module

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1097 trusty-quantum-gateway for brad-marshall mp241486
    LINT FAIL: lint-test failed

LINT Results (max last 5 lines):
INFO:root:Searching for: ['@flake8']
INFO:root:command: make -f Makefile lint
ERROR:root:Make target returned non-zero.
  hooks/quantum_utils.py:501:1: F811 redefinition of unused 'services' from line 405
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/9052970/
Build: http://10.98.191.181:8080/job/charm_lint_check/1097/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #931 trusty-quantum-gateway for brad-marshall mp241486
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/quantum_utils 204 5 98% 354, 407-410
  TOTAL 459 47 90%
  Ran 82 tests in 3.640s
  FAILED (errors=3)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/9052973/
Build: http://10.98.191.181:8080/job/charm_unit_test/931/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #439 trusty-quantum-gateway for brad-marshall mp241486
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv05"
  WARNING cannot delete security group "juju-osci-sv05-0". Used by another environment?
  juju-test INFO : Results: 1 passed, 2 failed, 0 errored
  ERROR subprocess encountered error code 2
  make: *** [test] Error 2

Full amulet test output: http://paste.ubuntu.com/9053032/
Build: http://10.98.191.181:8080/job/charm_amulet_test/439/

lp://staging/~brad-marshall/charms/trusty/quantum-gateway/add-nrpe-checks updated
81. By Brad Marshall

[bradm] Removed nagios check files that were moved to nrpe-external-master charm

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1113 trusty-quantum-gateway for brad-marshall mp241486
    LINT FAIL: lint-test failed

LINT Results (max last 5 lines):
INFO:root:command: make -f Makefile lint
ERROR:root:Make target returned non-zero.
  hooks/quantum_hooks.py:239:13: F841 local variable 'checkpath' is assigned to but never used
  hooks/quantum_utils.py:501:1: F811 redefinition of unused 'services' from line 405
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/9063849/
Build: http://10.98.191.181:8080/job/charm_lint_check/1113/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #947 trusty-quantum-gateway for brad-marshall mp241486
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/quantum_utils 204 5 98% 354, 407-410
  TOTAL 459 47 90%
  Ran 82 tests in 3.301s
  FAILED (errors=3)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/9063851/
Build: http://10.98.191.181:8080/job/charm_unit_test/947/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #455 trusty-quantum-gateway for brad-marshall mp241486
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  WARNING cannot delete security group "juju-osci-sv05". Used by another environment?
  WARNING cannot delete security group "juju-osci-sv05-0". Used by another environment?
  juju-test INFO : Results: 0 passed, 2 failed, 1 errored
  ERROR subprocess encountered error code 2
  make: *** [test] Error 2

Full amulet test output: http://paste.ubuntu.com/9064090/
Build: http://10.98.191.181:8080/job/charm_amulet_test/455/

lp://staging/~brad-marshall/charms/trusty/quantum-gateway/add-nrpe-checks updated
82. By Brad Marshall

[bradm] Add network namespace checks

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1141 trusty-quantum-gateway for brad-marshall mp241486
    LINT FAIL: lint-test failed

LINT Results (max last 5 lines):
INFO:root:Searching for: ['@flake8']
INFO:root:command: make -f Makefile lint
ERROR:root:Make target returned non-zero.
  hooks/quantum_utils.py:501:1: F811 redefinition of unused 'services' from line 405
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/9110737/
Build: http://10.98.191.181:8080/job/charm_lint_check/1141/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #975 trusty-quantum-gateway for brad-marshall mp241486
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/quantum_utils 204 5 98% 354, 407-410
  TOTAL 464 52 89%
  Ran 82 tests in 3.753s
  FAILED (errors=3)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/9110750/
Build: http://10.98.191.181:8080/job/charm_unit_test/975/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #483 trusty-quantum-gateway for brad-marshall mp241486
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv07"
  WARNING cannot delete security group "juju-osci-sv07-0". Used by another environment?
  juju-test INFO : Results: 1 passed, 2 failed, 0 errored
  ERROR subprocess encountered error code 2
  make: *** [test] Error 2

Full amulet test output: http://paste.ubuntu.com/9110796/
Build: http://10.98.191.181:8080/job/charm_amulet_test/483/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1247 trusty-quantum-gateway for brad-marshall mp241486
    LINT FAIL: lint-test failed

LINT Results (max last 5 lines):
INFO:root:Searching for: ['@flake8']
INFO:root:command: make -f Makefile lint
ERROR:root:Make target returned non-zero.
  hooks/quantum_utils.py:501:1: F811 redefinition of unused 'services' from line 405
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/9281278/
Build: http://10.98.191.181:8080/job/charm_lint_check/1247/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #1081 trusty-quantum-gateway for brad-marshall mp241486
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/quantum_utils 204 5 98% 354, 407-410
  TOTAL 464 52 89%
  Ran 82 tests in 3.144s
  FAILED (errors=3)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/9281281/
Build: http://10.98.191.181:8080/job/charm_unit_test/1081/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #550 trusty-quantum-gateway for brad-marshall mp241486
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv05"
  WARNING cannot delete security group "juju-osci-sv05-0". Used by another environment?
  juju-test INFO : Results: 1 passed, 2 failed, 0 errored
  ERROR subprocess encountered error code 2
  make: *** [test] Error 2

Full amulet test output: http://paste.ubuntu.com/9281399/
Build: http://10.98.191.181:8080/job/charm_amulet_test/550/

Revision history for this message
Liam Young (gnuoy) wrote :

Thank for the mp. The new nrpe support is very gratefully received !

I've taken this branch and centralised the common code between this and the other nrpe branches and moved it to charm-helpers. To land it I created a new branch from this one which has now been merged into the 'next' charm. The 'next' charms will overwrite the stable ones in a couple of weeks.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches