Juju Charms Collection
neutron-api package

Merge lp://staging/~brad-marshall/charms/trusty/neutron-api/add-nrpe-checks into lp://staging/~openstack-charmers-archive/charms/trusty/neutron-api/trunk

  1. Trusty Tahr (14.04)
  2. add-nrpe-checks
  3. Merge into trunk
Proposed by Brad Marshall
Status: Superseded
Proposed branch: lp://staging/~brad-marshall/charms/trusty/neutron-api/add-nrpe-checks
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/neutron-api/trunk
Diff against target: 981 lines (+858/-0)
11 files modified
charm-helpers-sync.yaml (+1/-0)
config.yaml (+10/-0)
files/nrpe-external-master/check_exit_status.pl (+189/-0)
files/nrpe-external-master/check_status_file.py (+60/-0)
files/nrpe-external-master/check_upstart_job (+72/-0)
files/nrpe-external-master/nagios_plugin.py (+78/-0)
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+222/-0)
hooks/charmhelpers/contrib/charmsupport/volumes.py (+156/-0)
hooks/neutron_api_hooks.py (+59/-0)
hooks/neutron_api_utils.py (+8/-0)
metadata.yaml (+3/-0)
To merge this branch: bzr merge lp://staging/~brad-marshall/charms/trusty/neutron-api/add-nrpe-checks
Reviewer Review Type Date Requested Status
Liam Young (community) Needs Fixing
Review via email: mp+241490@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-11-17.

Description of the change

Adds nrpe-external-master interface and adds basic nrpe checks.

To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #998 trusty-neutron-api for brad-marshall mp241490
    LINT FAIL: lint-test failed

LINT Results (max last 5 lines):
ERROR:root:Make target returned non-zero.
  hooks/neutron_api_hooks.py:377:80: E501 line too long (92 > 79 characters)
  hooks/neutron_api_hooks.py:398:18: E251 unexpected spaces around keyword / parameter equals
  hooks/neutron_api_hooks.py:398:20: E251 unexpected spaces around keyword / parameter equals
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/8955801/
Build: http://10.98.191.181:8080/job/charm_lint_check/998/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #833 trusty-neutron-api for brad-marshall mp241490
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/neutron_api_utils 90 7 92% 215-227
  TOTAL 361 48 87%
  Ran 49 tests in 3.083s
  FAILED (errors=1)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/8955810/
Build: http://10.98.191.181:8080/job/charm_unit_test/833/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_amulet_test #378 trusty-neutron-api for brad-marshall mp241490
    AMULET FAIL: amulet-test missing

AMULET Results (max last 5 lines):
INFO:root:Workspace dir: /var/lib/jenkins/workspace/charm_amulet_test
INFO:root:Reading file: Makefile
INFO:root:Searching for: ['@juju test']
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/8955978/
Build: http://10.98.191.181:8080/job/charm_amulet_test/378/

Revision history for this message
Liam Young (gnuoy) wrote :

Also, could you move the check_upstart_job into charmhelpers as it seems to be common across these mps?

Revision history for this message
Liam Young (gnuoy) wrote :

Other than putting check_upstart_job into charmhelpers this lgtm

review: Approve
Revision history for this message
Liam Young (gnuoy) wrote :

Sorry, that was approved in error. I'd like to wait on the check_upstart_job move

review: Needs Fixing
lp://staging/~brad-marshall/charms/trusty/neutron-api/add-nrpe-checks updated
68. By Brad Marshall

[bradm] Added nrpe checks for sysvinit daemons, change to using services() instead of hard coded daemon list, pep8 fixes.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1089 trusty-neutron-api for brad-marshall mp241490
    LINT OK: passed

LINT Results (max last 5 lines):
  I: config.yaml: option ssl_ca has no default value
  I: config.yaml: option ssl_cert has no default value
  I: config.yaml: option os-internal-network has no default value
  I: config.yaml: option os-public-network has no default value
  I: config.yaml: option nsx-tz-uuid has no default value

Full lint test output: http://paste.ubuntu.com/9052160/
Build: http://10.98.191.181:8080/job/charm_lint_check/1089/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #923 trusty-neutron-api for brad-marshall mp241490
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/neutron_api_utils 95 11 88% 177-180, 223-235
  TOTAL 380 65 83%
  Ran 49 tests in 2.920s
  FAILED (errors=1)
  make: *** [unit_test] Error 1

Full unit test output: http://paste.ubuntu.com/9052176/
Build: http://10.98.191.181:8080/job/charm_unit_test/923/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #431 trusty-neutron-api for brad-marshall mp241490
    AMULET FAIL: amulet-test missing

AMULET Results (max last 5 lines):
INFO:root:Workspace dir: /var/lib/jenkins/workspace/charm_amulet_test
INFO:root:Reading file: Makefile
INFO:root:Searching for: ['@juju test']
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/9052233/
Build: http://10.98.191.181:8080/job/charm_amulet_test/431/

lp://staging/~brad-marshall/charms/trusty/neutron-api/add-nrpe-checks updated
69. By Brad Marshall

[bradm] Removed puppet header from nagios_plugin module

70. By Brad Marshall

[bradm] Removed nagios check files that were moved to nrpe-external-master charm

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches