Merge charm-openstack-service-checks:ignore-unbound-ports into charm-openstack-service-checks:master
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Ramesh Sattaru | ||||
| Approved revision: | 8c3825673ffd8a5d16f6428c1c4c798e6bf23e8d | ||||
| Merged at revision: | 00dc62e0c31035e2df8c0d46cb58829e3db4f64b | ||||
| Proposed branch: | charm-openstack-service-checks:ignore-unbound-ports | ||||
| Merge into: | charm-openstack-service-checks:master | ||||
| Diff against target: |
69 lines (+22/-3) 2 files modified
src/files/plugins/check_resources.py (+5/-0) src/tests/unit/test_check_resources.py (+17/-3) |
||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| JamesLin | Approve | ||
| Chi Wai CHAN | Approve | ||
| 🤖 prod-jenkaas-bootstack (community) | continuous-integration | Approve | |
| Tianqi Xiao (community) | Needs Fixing | ||
| BootStack Reviewers | Pending | ||
|
Review via email:
|
|||
Commit message
Ignore unbound ports on check_ports
Description of the change
This MR will filter unbound ports on the `check_ports` Nagios check.
Unbound ports are generally DOWN, and Nagios will fire the `check_ports` alert if any port is down. However, since the unbound ports are always DOWN, this alert will generate noise if there are any unbound ports, forcing operators to deal with the noise by adding these port IDs to the skip list. However, if any of the ignored ports are bound, they will remain in the skip list which is undesired. This MR will now filter unbound ports from the check so that (a) operators don't have to deal with the noise and (b) these ports are automatically re-added to the check once bound.
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
| 🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote | # |
| 🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote | # |
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.