telephony-service

Merge lp://staging/~boiko/telephony-service/fix_voicemail_detection into lp://staging/telephony-service

fix_voicemail_detection
Merge into trunk

Proposed by Gustavo Pichorim Boiko on 2015-04-28

Status:

Merged

Approved by:

Tiago Salem Herrmann on 2015-05-11

Approved revision:

1083

Merged at revision:

1071

Proposed branch:

lp://staging/~boiko/telephony-service/fix_voicemail_detection

Merge into:

lp://staging/telephony-service

Diff against target:

1384 lines (+342/-159)

20 files modified

.bzrignore (+1/-0)
cmake/modules/GenerateTest.cmake (+0/-1)
libtelephonyservice/accountentry.cpp (+7/-2)
libtelephonyservice/accountentry.h (+2/-0)
libtelephonyservice/callentry.cpp (+1/-1)
libtelephonyservice/ofonoaccountentry.cpp (+3/-1)
libtelephonyservice/telepathyhelper.cpp (+1/-0)
libtelephonyservice/telepathyhelper.h (+1/-0)
tests/common/mock/connection.cpp (+10/-2)
tests/common/mock/connection.h (+1/-0)
tests/common/mock/mockconnectiondbus.cpp (+24/-0)
tests/common/telepathytest.cpp (+13/-20)
tests/common/telepathytest.h (+7/-1)
tests/handler/HandlerTest.cpp (+23/-26)
tests/libtelephonyservice/AccountEntryTest.cpp (+30/-34)
tests/libtelephonyservice/CMakeLists.txt (+1/-0)
tests/libtelephonyservice/CallEntryTest.cpp (+129/-0)
tests/libtelephonyservice/ChatManagerTest.cpp (+9/-13)
tests/libtelephonyservice/OfonoAccountEntryTest.cpp (+29/-31)
tests/libtelephonyservice/TelepathyHelperTest.cpp (+50/-27)

To merge this branch:

bzr merge lp://staging/~boiko/telephony-service/fix_voicemail_detection

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2015-05-12
Tiago Salem Herrmann (community)		2015-04-28	Approve on 2015-05-11
Review via email: mp+257694@code.staging.launchpad.net

Commit message

Fix voicemail detection on CallEntry.

Description of the change

Fix voicemail detection on CallEntry.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-28:

PASSED: Continuous integration, rev:1065
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/425/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/93
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/93
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/93/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/93

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/425/rebuild

review: Approve (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-04-28

1066. By Gustavo Pichorim Boiko on 2015-04-28: Try to fix some flakiness.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-29:

FAILED: Continuous integration, rev:1066
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/427/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/95/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/95
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/95/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/95/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/427/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-04-29

1067. By Gustavo Pichorim Boiko on 2015-04-29: Increase the timeout of all tests so that slow builders don't fail.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-29:

FAILED: Continuous integration, rev:1067
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/428/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/96
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/96/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/96

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/428/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-04-29

1068. By Gustavo Pichorim Boiko on 2015-04-29: Change the tests in a hope to finally remove the flakiness.
1069. By Gustavo Pichorim Boiko on 2015-04-29: Fix some possible points of flakiness. The connectedChanged() signal might be emitted more than just once.
1070. By Gustavo Pichorim Boiko on 2015-04-29: Use the account from telepathyhelper in the callentry test.
1071. By Gustavo Pichorim Boiko on 2015-04-29: Re-add dbus-monitor to debug the test failures.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-29:

PASSED: Continuous integration, rev:1068
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/429/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/97
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/97/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/97

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/429/rebuild

review: Approve (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-04-29

1072. By Gustavo Pichorim Boiko on 2015-04-29: And one more.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-29:

PASSED: Continuous integration, rev:1072
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/430/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/98
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/98
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/98/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/98

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/430/rebuild

review: Approve (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-04-29

1073. By Gustavo Pichorim Boiko on 2015-04-29: Only set mReady when the connection is actually ready.
1074. By Gustavo Pichorim Boiko on 2015-04-29: Revert the mReady change.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-29:

PASSED: Continuous integration, rev:1074
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/431/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/99
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/99
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/99/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/99

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/431/rebuild

review: Approve (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-04-30

1075. By Gustavo Pichorim Boiko on 2015-04-30: Sometimes multiple status changed signals are emitted, so account for that in the tests.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-30:

PASSED: Continuous integration, rev:1075
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/432/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/100
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/100
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/100

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/432/rebuild

review: Approve (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-05-07

1076. By Gustavo Pichorim Boiko on 2015-05-07: Some more test fixes.
1077. By Gustavo Pichorim Boiko on 2015-05-07: Merge latest changes from trunk.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-05-07:

FAILED: Continuous integration, rev:1077
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/433/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/101/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/101/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/101/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/433/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-05-07

1078. By Gustavo Pichorim Boiko on 2015-05-07: Add debug on the mock dbus calls.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-05-07:

FAILED: Continuous integration, rev:1078
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/434/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/102
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/102/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/102

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/434/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-05-08

1079. By Gustavo Pichorim Boiko on 2015-05-08: Wait for the AccountEntry to change the status.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-05-08:

FAILED: Continuous integration, rev:1079
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/435/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/103
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/103/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/103

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/435/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-05-08

1080. By Gustavo Pichorim Boiko on 2015-05-08: Only set offline when really necessary.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-05-08:

FAILED: Continuous integration, rev:1080
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/436/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/104/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/104/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/104

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/436/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~boiko/telephony-service/fix_voicemail_detection updated on 2015-05-08

1081. By Gustavo Pichorim Boiko on 2015-05-08: Fix some more flakiness points.
1082. By Gustavo Pichorim Boiko on 2015-05-08: Ignore status changes from the client side to mimic the behavior of telepathy-ofono.