Merge lp://staging/~boiko/history-service/move_private_to_shared_lib into lp://staging/history-service

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 253
Merged at revision: 215
Proposed branch: lp://staging/~boiko/history-service/move_private_to_shared_lib
Merge into: lp://staging/history-service
Prerequisite: lp://staging/~boiko/history-service/cached_contact_matching
Diff against target: 809 lines (+106/-93)
30 files modified
CMakeLists.txt (+0/-1)
Ubuntu/History/CMakeLists.txt (+0/-2)
Ubuntu/History/historyeventmodel.cpp (+1/-1)
Ubuntu/History/historymodel.cpp (+5/-5)
cmake/modules/GenerateTest.cmake (+1/-1)
daemon/CMakeLists.txt (+0/-2)
daemon/historydaemon.cpp (+4/-4)
historyprivate/CMakeLists.txt (+0/-22)
plugins/sqlite/CMakeLists.txt (+1/-2)
plugins/sqlite/schema/CMakeLists.txt (+1/-1)
plugins/sqlite/sqlitedatabase.cpp (+2/-2)
plugins/sqlite/sqlitehistoryplugin.cpp (+7/-7)
src/CMakeLists.txt (+12/-4)
src/channelobserver.cpp (+5/-0)
src/channelobserver_p.h (+5/-0)
src/contactmatcher.cpp (+9/-4)
src/contactmatcher_p.h (+5/-0)
src/phoneutils.cpp (+5/-0)
src/phoneutils_p.h (+5/-0)
src/telepathyhelper.cpp (+5/-0)
src/telepathyhelper_p.h (+5/-0)
tests/CMakeLists.txt (+0/-1)
tests/common/CMakeLists.txt (+2/-2)
tests/common/telepathytest.cpp (+2/-2)
tests/daemon/CMakeLists.txt (+0/-1)
tests/daemon/DaemonTest.cpp (+3/-3)
tests/historyprivate/CMakeLists.txt (+0/-12)
tests/libhistoryservice/CMakeLists.txt (+7/-0)
tests/libhistoryservice/ContactMatcherTest.cpp (+12/-12)
tests/libhistoryservice/PhoneUtilsTest.cpp (+2/-2)
To merge this branch: bzr merge lp://staging/~boiko/history-service/move_private_to_shared_lib
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+272608@code.staging.launchpad.net

Commit message

Move the classes from historyprivate static library to libhistoryservice itself and just keep their header files private.

Description of the change

Move the classes from historyprivate static library to libhistoryservice itself and just keep their header files private.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
229. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
230. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
231. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
232. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
233. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
234. By Gustavo Pichorim Boiko

Merge parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
235. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
236. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
237. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
238. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
239. By Gustavo Pichorim Boiko

Merge latest changes from parent.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
240. By Gustavo Pichorim Boiko

Merge latest changes from parent.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
241. By Gustavo Pichorim Boiko

Merge parent branch.

242. By Gustavo Pichorim Boiko

Merge parent branch

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
243. By Gustavo Pichorim Boiko

Merge parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
244. By Gustavo Pichorim Boiko

Merge parent branch.

245. By Gustavo Pichorim Boiko

Merge changes from parent.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
246. By Gustavo Pichorim Boiko

Move TelepathyHelper to the History namespace.

247. By Gustavo Pichorim Boiko

Move PhoneUtils to History namespace.

248. By Gustavo Pichorim Boiko

Move ContactMatcher to History namespace.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
249. By Gustavo Pichorim Boiko

Move ChannelObserver to History namespace.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
250. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
251. By Gustavo Pichorim Boiko

Merge changes from parent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
252. By Gustavo Pichorim Boiko

Merge latest changes from parent branch.

253. By Gustavo Pichorim Boiko

Merge latest changes from parent.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good.
Thanks.

review: Approve
254. By Gustavo Pichorim Boiko

Merge parent changes

255. By Gustavo Pichorim Boiko

Merge parent branch

256. By Gustavo Pichorim Boiko

Merge parent.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches