Merge lp://staging/~boiko/history-service/move_private_to_shared_lib into lp://staging/history-service
- move_private_to_shared_lib
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Tiago Salem Herrmann |
Approved revision: | 253 |
Merged at revision: | 215 |
Proposed branch: | lp://staging/~boiko/history-service/move_private_to_shared_lib |
Merge into: | lp://staging/history-service |
Prerequisite: | lp://staging/~boiko/history-service/cached_contact_matching |
Diff against target: |
809 lines (+106/-93) 30 files modified
CMakeLists.txt (+0/-1) Ubuntu/History/CMakeLists.txt (+0/-2) Ubuntu/History/historyeventmodel.cpp (+1/-1) Ubuntu/History/historymodel.cpp (+5/-5) cmake/modules/GenerateTest.cmake (+1/-1) daemon/CMakeLists.txt (+0/-2) daemon/historydaemon.cpp (+4/-4) historyprivate/CMakeLists.txt (+0/-22) plugins/sqlite/CMakeLists.txt (+1/-2) plugins/sqlite/schema/CMakeLists.txt (+1/-1) plugins/sqlite/sqlitedatabase.cpp (+2/-2) plugins/sqlite/sqlitehistoryplugin.cpp (+7/-7) src/CMakeLists.txt (+12/-4) src/channelobserver.cpp (+5/-0) src/channelobserver_p.h (+5/-0) src/contactmatcher.cpp (+9/-4) src/contactmatcher_p.h (+5/-0) src/phoneutils.cpp (+5/-0) src/phoneutils_p.h (+5/-0) src/telepathyhelper.cpp (+5/-0) src/telepathyhelper_p.h (+5/-0) tests/CMakeLists.txt (+0/-1) tests/common/CMakeLists.txt (+2/-2) tests/common/telepathytest.cpp (+2/-2) tests/daemon/CMakeLists.txt (+0/-1) tests/daemon/DaemonTest.cpp (+3/-3) tests/historyprivate/CMakeLists.txt (+0/-12) tests/libhistoryservice/CMakeLists.txt (+7/-0) tests/libhistoryservice/ContactMatcherTest.cpp (+12/-12) tests/libhistoryservice/PhoneUtilsTest.cpp (+2/-2) |
To merge this branch: | bzr merge lp://staging/~boiko/history-service/move_private_to_shared_lib |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tiago Salem Herrmann (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+272608@code.staging.launchpad.net |
Commit message
Move the classes from historyprivate static library to libhistoryservice itself and just keep their header files private.
Description of the change
Move the classes from historyprivate static library to libhistoryservice itself and just keep their header files private.
PS Jenkins bot (ps-jenkins) wrote : | # |
- 229. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:229
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 230. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:230
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 231. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:231
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 232. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:232
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 233. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:233
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 234. By Gustavo Pichorim Boiko
-
Merge parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:234
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 235. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:235
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 236. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:236
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 237. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:237
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 238. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:238
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 239. By Gustavo Pichorim Boiko
-
Merge latest changes from parent.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:239
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 240. By Gustavo Pichorim Boiko
-
Merge latest changes from parent.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:240
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 241. By Gustavo Pichorim Boiko
-
Merge parent branch.
- 242. By Gustavo Pichorim Boiko
-
Merge parent branch
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:242
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 243. By Gustavo Pichorim Boiko
-
Merge parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:243
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 244. By Gustavo Pichorim Boiko
-
Merge parent branch.
- 245. By Gustavo Pichorim Boiko
-
Merge changes from parent.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:244
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:245
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 246. By Gustavo Pichorim Boiko
-
Move TelepathyHelper to the History namespace.
- 247. By Gustavo Pichorim Boiko
-
Move PhoneUtils to History namespace.
- 248. By Gustavo Pichorim Boiko
-
Move ContactMatcher to History namespace.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:248
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 249. By Gustavo Pichorim Boiko
-
Move ChannelObserver to History namespace.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:249
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 250. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:250
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 251. By Gustavo Pichorim Boiko
-
Merge changes from parent branch.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:251
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 252. By Gustavo Pichorim Boiko
-
Merge latest changes from parent branch.
- 253. By Gustavo Pichorim Boiko
-
Merge latest changes from parent.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:253
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Tiago Salem Herrmann (tiagosh) wrote : | # |
Looks good.
Thanks.
- 254. By Gustavo Pichorim Boiko
-
Merge parent changes
- 255. By Gustavo Pichorim Boiko
-
Merge parent branch
- 256. By Gustavo Pichorim Boiko
-
Merge parent.
PASSED: Continuous integration, rev:228 jenkins. qa.ubuntu. com/job/ history- service- ci/247/ jenkins. qa.ubuntu. com/job/ history- service- vivid-amd64- ci/85 jenkins. qa.ubuntu. com/job/ history- service- vivid-armhf- ci/86 jenkins. qa.ubuntu. com/job/ history- service- vivid-armhf- ci/86/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ history- service- vivid-i386- ci/85
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/history- service- ci/247/ rebuild
http://