history-service

Merge lp://staging/~boiko/history-service/modify_events into lp://staging/history-service

  1. modify_events
  2. Merge into trunk
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 100
Merged at revision: 98
Proposed branch: lp://staging/~boiko/history-service/modify_events
Merge into: lp://staging/history-service
Diff against target: 509 lines (+196/-32)
13 files modified
Ubuntu/History/historyeventmodel.cpp (+56/-6)
Ubuntu/History/historyeventmodel.h (+6/-0)
daemon/historydaemon.cpp (+21/-6)
plugins/sqlite/sqlitehistoryplugin.cpp (+58/-15)
plugins/sqlite/sqlitehistoryplugin.h (+2/-2)
plugins/sqlite/sqlitehistorythreadview.cpp (+1/-1)
src/event.cpp (+12/-0)
src/event.h (+1/-0)
src/plugin.h (+2/-2)
src/tests/TextEventTest.cpp (+16/-0)
src/textevent.cpp (+12/-0)
src/textevent.h (+2/-0)
src/types.h (+7/-0)
To merge this branch: bzr merge lp://staging/~boiko/history-service/modify_events
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+186644@code.staging.launchpad.net

Commit message

Make it possible to modify events.

Description of the change

Make it possible to modify events.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:97
http://jenkins.qa.ubuntu.com/job/history-service-ci/60/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-amd64-ci/60
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/61/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-i386-ci/60

Click here to trigger a rebuild:
http://s-jenkins:8080/job/history-service-ci/60/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:97
http://jenkins.qa.ubuntu.com/job/history-service-ci/61/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-amd64-ci/61
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/62
        deb: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/62/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-i386-ci/61

Click here to trigger a rebuild:
http://s-jenkins:8080/job/history-service-ci/61/rebuild

review: Approve (continuous-integration)
lp://staging/~boiko/history-service/modify_events updated
98. By Gustavo Pichorim Boiko

Make sure we don't duplicate the event on the model.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:98
http://jenkins.qa.ubuntu.com/job/history-service-ci/62/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-amd64-ci/62
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/63
        deb: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/63/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-i386-ci/62

Click here to trigger a rebuild:
http://s-jenkins:8080/job/history-service-ci/62/rebuild

review: Approve (continuous-integration)
lp://staging/~boiko/history-service/modify_events updated
99. By Gustavo Pichorim Boiko

Return the correct value when writing text events.

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

I think it is better to kill the previous timer and start a new one, so when scrolling the view we dont get lots of updates from the history-service each 500ms.

review: Needs Fixing
lp://staging/~boiko/history-service/modify_events updated
100. By Gustavo Pichorim Boiko

Reset the timer every time a new item arrives (this helps improving the
performance while scrolling the lists).

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:99
http://jenkins.qa.ubuntu.com/job/history-service-ci/63/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-saucy-amd64-ci/63/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/64
        deb: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/64/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-i386-ci/63

Click here to trigger a rebuild:
http://s-jenkins:8080/job/history-service-ci/63/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

I am seeing lots of issues when removing entries, and still seeing dbus traffic (EventsModified) while scrolling the contact list even after all the conversation thread is retrieved by the app.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:99
http://jenkins.qa.ubuntu.com/job/history-service-ci/64/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-amd64-ci/64
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/65
        deb: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/65/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-i386-ci/64

Click here to trigger a rebuild:
http://s-jenkins:8080/job/history-service-ci/64/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:100
http://jenkins.qa.ubuntu.com/job/history-service-ci/65/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-amd64-ci/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/66
        deb: http://jenkins.qa.ubuntu.com/job/history-service-saucy-armhf-ci/66/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-saucy-i386-ci/65

Click here to trigger a rebuild:
http://s-jenkins:8080/job/history-service-ci/65/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

The issues were caused because of duplicate entries created by a previous commit.
Just tried using a new database and I was unable to reproduce any issues.
+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches