history-service

Merge lp://staging/~boiko/history-service/fix_group_thread_matching into lp://staging/history-service

Proposed by Gustavo Pichorim Boiko on 2015-01-28

Status:	Merged
Approved by:	Tiago Salem Herrmann on 2015-01-29
Approved revision:	183
Merged at revision:	184
Proposed branch:	lp://staging/~boiko/history-service/fix_group_thread_matching
Merge into:	lp://staging/history-service
Diff against target:	397 lines (+159/-51) 6 files modified plugins/sqlite/sqlitehistoryeventview.cpp (+14/-2) plugins/sqlite/sqlitehistoryplugin.cpp (+6/-22) plugins/sqlite/sqlitehistoryplugin.h (+1/-1) plugins/sqlite/sqlitehistorythreadview.cpp (+14/-2) plugins/sqlite/tests/SqlitePluginTest.cpp (+31/-13) src/tests/EventViewTest.cpp (+93/-11)
To merge this branch:	bzr merge lp://staging/~boiko/history-service/fix_group_thread_matching
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Tiago Salem Herrmann (community)		2015-01-28	Approve on 2015-01-29
PS Jenkins bot	continuous-integration		Approve on 2015-01-29
Review via email: mp+247916@code.staging.launchpad.net

Use QSqlQuery::bindValue() to pass filter arguments to the query to prevent errors.

Use QSqlQuery::bindValue() to pass filter arguments to the query to prevent errors.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

Revision history for this message