Merge lp://staging/~boiko/history-service/escape_strings into lp://staging/history-service

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 183
Merged at revision: 181
Proposed branch: lp://staging/~boiko/history-service/escape_strings
Merge into: lp://staging/history-service
Diff against target: 128 lines (+45/-6)
3 files modified
plugins/sqlite/sqlitehistoryplugin.cpp (+12/-2)
plugins/sqlite/sqlitehistoryplugin.h (+1/-0)
plugins/sqlite/tests/SqlitePluginTest.cpp (+32/-4)
To merge this branch: bzr merge lp://staging/~boiko/history-service/escape_strings
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+247517@code.staging.launchpad.net

Commit message

Make sure string filters are correctly escaped.

Description of the change

Make sure string filters are correctly escaped.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
182. By Gustavo Pichorim Boiko

Also escape partial matches.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
183. By Gustavo Pichorim Boiko

Use single quotes for string literals and escape the characters properly.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good.

--Checklist--
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches