Merge lp://staging/~boiko/history-service/escape_strings into lp://staging/history-service
| Status: | Merged |
|---|---|
| Approved by: | Tiago Salem Herrmann |
| Approved revision: | 183 |
| Merged at revision: | 181 |
| Proposed branch: | lp://staging/~boiko/history-service/escape_strings |
| Merge into: | lp://staging/history-service |
| Diff against target: |
128 lines (+45/-6) 3 files modified
plugins/sqlite/sqlitehistoryplugin.cpp (+12/-2) plugins/sqlite/sqlitehistoryplugin.h (+1/-0) plugins/sqlite/tests/SqlitePluginTest.cpp (+32/-4) |
| To merge this branch: | bzr merge lp://staging/~boiko/history-service/escape_strings |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tiago Salem Herrmann (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Make sure string filters are correctly escaped.
Description of the change
Make sure string filters are correctly escaped.
== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes
Did you successfully run all tests found in your component's Test Plan (https:/
Yes
If you changed the UI, was the change specified/approved by design?
N/A
If you changed UI labels, did you update the pot file?
N/A
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
FAILED: Continuous integration, rev:181
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://