Merge lp://staging/~boiko/history-service/custom_functions_in_schema_generation into lp://staging/history-service

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 206
Merged at revision: 210
Proposed branch: lp://staging/~boiko/history-service/custom_functions_in_schema_generation
Merge into: lp://staging/history-service
Diff against target: 222 lines (+130/-18)
5 files modified
plugins/sqlite/schema/CMakeLists.txt (+8/-2)
plugins/sqlite/schema/generate_schema.cpp (+62/-0)
plugins/sqlite/schema/update_schema.sh.in (+3/-4)
plugins/sqlite/sqlitedatabase.cpp (+53/-11)
plugins/sqlite/sqlitedatabase.h (+4/-1)
To merge this branch: bzr merge lp://staging/~boiko/history-service/custom_functions_in_schema_generation
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+269964@code.staging.launchpad.net

Commit message

Make it possible to use the custom functions defined by the sqlite plugin in the
schema files themselves.

Description of the change

Make it possible to use the custom functions defined by the sqlite plugin in the
schema files themselves.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
204. By Gustavo Pichorim Boiko

Add missing copyright.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
205. By Gustavo Pichorim Boiko

If the database is up-to-date, don't try to run an empty list of statements.

206. By Gustavo Pichorim Boiko

Add a message saying the failure output is expected during schema generation.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches