dialer-app

Merge lp://staging/~boiko/dialer-app/notify_conference_and_holding_errors into lp://staging/dialer-app

  1. notify_conference_and_holding_errors
  2. Merge into trunk
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 344
Merged at revision: 343
Proposed branch: lp://staging/~boiko/dialer-app/notify_conference_and_holding_errors
Merge into: lp://staging/dialer-app
Diff against target: 170 lines (+42/-36)
4 files modified
src/qml/Dialogs/NotificationDialog.qml (+11/-13)
src/qml/LiveCallPage/LiveCall.qml (+22/-2)
src/qml/LiveCallPage/MultiCallDisplay.qml (+1/-1)
src/qml/dialer-app.qml (+8/-20)
To merge this branch: bzr merge lp://staging/~boiko/dialer-app/notify_conference_and_holding_errors
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+247483@code.staging.launchpad.net

Commit message

Notify error when trying to create conference calls and when changing the call hold status.

Description of the change

Notify error when trying to create conference calls and when changing the call hold status.

== Checklist ==
== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~tiagosh/telepathy-ofono/set-hold-reason/+merge/246948
https://code.launchpad.net/~boiko/telephony-service/notify_conf_and_hold_errors/+merge/246951

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
Yes

If you changed UI labels, did you update the pot file?
Will update after the merge

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:344
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/505/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-vivid-i386-ci/15
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/968
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/438
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/858
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/966
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/966/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17405
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/358
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/530
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/530/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/505/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good. Tested on the device and it works fine.

--Checklist--
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but it is not related to the changes.

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches