dialer-app

Merge lp://staging/~boiko/dialer-app/history_all_missed into lp://staging/dialer-app

history_all_missed
Merge into trunk

Proposed by Gustavo Pichorim Boiko on 2014-08-25

Status:

Merged

Approved by:

Tiago Salem Herrmann on 2014-08-29

Approved revision:

248

Merged at revision:

245

Proposed branch:

lp://staging/~boiko/dialer-app/history_all_missed

Merge into:

lp://staging/dialer-app

Diff against target:

339 lines (+84/-58)

3 files modified

po/dialer-app.pot (+22/-20)
src/qml/DialerPage/DialerPage.qml (+8/-1)
src/qml/HistoryPage/HistoryPage.qml (+54/-37)

To merge this branch:

bzr merge lp://staging/~boiko/dialer-app/history_all_missed

Related bugs:

Bug #1320437: Please update the translations template file	High	Fix Released
Bug #1352415: [dialer-app] all missed tabs are missing in section, beneath the header	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Tiago Salem Herrmann (community)		2014-08-25	Approve on 2014-08-29
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-08-27
Review via email: mp+232077@code.staging.launchpad.net

Commit message

Add All/Missed categories to the call log page.

Description of the change

Add All/Missed categories to the call log page.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
Yes

If you changed UI labels, did you update the pot file?
Yes

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

lp://staging/~boiko/dialer-app/history_all_missed updated on 2014-08-25

245. By Gustavo Pichorim Boiko on 2014-08-25: Remove unused variable.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-25:

FAILED: Continuous integration, rev:245
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/416/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/187
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3991
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3071
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3835
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5241
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5241/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12037
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2505
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3356
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3356/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/416/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-25:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/419/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Tiago Salem Herrmann (tiagosh) wrote on 2014-08-26:

if you tap "missed" and close the recents page, when you open it again using the bottom edge swipe, the list still has only missed entries, but "all" is selected.

review: Needs Fixing

lp://staging/~boiko/dialer-app/history_all_missed updated on 2014-08-27

246. By Gustavo Pichorim Boiko on 2014-08-27: Merge latest changes from trunk.
247. By Gustavo Pichorim Boiko on 2014-08-27: Reload the history page all the time to avoid bottom edge freezes.
248. By Gustavo Pichorim Boiko on 2014-08-27: Update pot.