dialer-app

Merge lp://staging/~boiko/dialer-app/fix_timestamps into lp://staging/dialer-app

fix_timestamps
Merge into trunk

Proposed by Gustavo Pichorim Boiko on 2014-10-21

Status:

Merged

Approved by:

Arthur Mello on 2014-11-11

Approved revision:

303

Merged at revision:

314

Proposed branch:

lp://staging/~boiko/dialer-app/fix_timestamps

Merge into:

lp://staging/dialer-app

Diff against target:

25 lines (+2/-2)

2 files modified

src/qml/HistoryPage/HistoryDelegate.qml (+1/-1)
src/qml/HistoryPage/HistoryDetailsPage.qml (+1/-1)

To merge this branch:

bzr merge lp://staging/~boiko/dialer-app/fix_timestamps

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Arthur Mello (community)		2014-10-21	Approve on 2014-11-11
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-10-21
Review via email: mp+239068@code.staging.launchpad.net

Commit message

Format timestamps according to the locale.

Description of the change

Format timestamps according to the locale.

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

lp://staging/~boiko/dialer-app/fix_timestamps updated on 2014-10-21

303. By Gustavo Pichorim Boiko on 2014-10-21: Fix the timestamp also in the call history details.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-21:

FAILED: Continuous integration, rev:303
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/484/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/255
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6104
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4159
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5730
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7356
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7356/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14910
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3520
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4504
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4504/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/484/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Arthur Mello (artmello) wrote on 2014-11-11:

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve