Merge lp://staging/~bogdana/landscape-client/mocker-manager-test-packagemanager into lp://staging/~landscape/landscape-client/trunk

Proposed by Bogdana Vereha
Status: Merged
Approved by: Bogdana Vereha
Approved revision: 889
Merged at revision: 899
Proposed branch: lp://staging/~bogdana/landscape-client/mocker-manager-test-packagemanager
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 418 lines (+110/-132)
1 file modified
landscape/manager/tests/test_packagemanager.py (+110/-132)
To merge this branch: bzr merge lp://staging/~bogdana/landscape-client/mocker-manager-test-packagemanager
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Review via email: mp+297654@code.staging.launchpad.net

Commit message

Update manager.test_packagemanager to use mock instead of mocker

Description of the change

Update manager.test_packagemanager to use mock instead of mocker

Testing instructions:
unittests

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 888
Branch: lp:~bogdana/landscape-client/mocker-manager-test-packagemanager
Jenkins: https://ci.lscape.net/job/latch-test/5099/

review: Approve (test results)
Revision history for this message
Chris Glass (tribaal) wrote :

+1 with a nit inline.

review: Approve
889. By Bogdana Vereha

Formatting changes

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 889
Branch: lp:~bogdana/landscape-client/mocker-manager-test-packagemanager
Jenkins: https://ci.lscape.net/job/latch-test/5103/

review: Approve (test results)
Revision history for this message
Adam Collard (adam-collard) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: