lp://staging/~blue-shell/blue-shell/libkpeople

Created by Rohan Garg and last modified
Get this branch:
bzr branch lp://staging/~blue-shell/blue-shell/libkpeople

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Blue-Shell
Project:
blue-shell
Status:
Development

Import details

Import Status: Suspended

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/libkpeople.

Last successful import was .

Import started on pear and finished taking 15 seconds — see the log
Import started on pear and finished taking 15 seconds — see the log
Import started on neumayer and finished taking 40 seconds — see the log
Import started on pear and finished taking 15 seconds — see the log

Recent revisions

528. By Aleix Pol

Semantic change, don't use Id, prefer Uri

Reason being, contactId can be read as a contact identifier. This can be
misleading as we're talking about such uri unique identifier within
kpeople.
contactId -> contactUri
personId -> personUri

527. By Aleix Pol

Don't fail silently

Add a warning if we couldn't find a person data to fetch for the requested
contactId.

526. By Aleix Pol

Add a PersonsModelTest

For the moment loads a fake source and makes sure it's reporting correctly.

525. By Aleix Pol

Proper initialization

Needs to be marked as slot, as invokeMethod doesn't work with
C++11 syntax, apperently.

524. By Aleix Pol

Don't use the operator[] when fetching by value

Otherwise it creates an null slot if it's not found.

523. By Aleix Pol

Fix connections to onMonitorInitialFetchComplete

It's in the d-pointer now

522. By Aleix Pol

Fix code path for initially fetched monitors.

It didn't make sense, it was passing the value through the signature
within SLOT()

521. By Aleix Pol

Run kdelibs-astyle

As suggested by:
https://community.kde.org/Frameworks/CreationGuidelines

520. By Aleix Pol

Improve KPeople documentation

Adds a README.md and a metainfo.yaml.
It also documents some classes and methods that didn't have any
documentation.

REVIEW: 122453

519. By Aleix Pol

Move private methods/slots and slots from PersonsModel to Private class

Move the private methods into the p-impl. First, it's the correct thing to
do. Secondly, it was pulling an awkward dependency on abstractcontact.h
from the backends into a public header.

REVIEW: 122428

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers