LAZR-PostgreSQL

Merge lp://staging/~bloodearnest/lazr-postgresql/schema into lp://staging/lazr-postgresql

  1. schema
  2. Merge into trunk
Proposed by Simon Davy
Status: Merged
Merged at revision: 25
Proposed branch: lp://staging/~bloodearnest/lazr-postgresql/schema
Merge into: lp://staging/lazr-postgresql
Diff against target: 268 lines (+61/-33)
4 files modified
src/lazr/postgresql/migrate.py (+11/-2)
src/lazr/postgresql/tests/test_migrate.py (+17/-3)
src/lazr/postgresql/tests/test_upgrade.py (+17/-17)
src/lazr/postgresql/upgrade.py (+16/-11)
To merge this branch: bzr merge lp://staging/~bloodearnest/lazr-postgresql/schema
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+328173@code.staging.launchpad.net

Commit message

Add support for specifying a schema to apply migrations to

Description of the change

Add support for explicit schemas

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) wrote :

Looks OK - just the SQL injection issue jumps out (see inline)

Revision history for this message
William Grant (wgrant) wrote :

Your whoami needs fixing and recommitting. And one minor SQL injection comment.

review: Approve (code)
Revision history for this message
Simon Davy (bloodearnest) wrote :

I've fixed the b0rked commit history, and used query params

Revision history for this message
Simon Davy (bloodearnest) wrote :

Looks like I can't top approve.

lp://staging/~bloodearnest/lazr-postgresql/schema updated
25. By Simon Davy

Add support for running migrations within a specific schema

Revision history for this message
Simon Davy (bloodearnest) wrote :

Really fixed the history now

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: