Juju Charms Collection
apache2 package

Merge lp://staging/~bloodearnest/charms/trusty/apache2/vhost_template_vars into lp://staging/charms/trusty/apache2

  1. Trusty Tahr (14.04)
  2. vhost_template_vars
  3. Merge into trunk
Proposed by Simon Davy
Status: Merged
Merged at revision: 62
Proposed branch: lp://staging/~bloodearnest/charms/trusty/apache2/vhost_template_vars
Merge into: lp://staging/charms/trusty/apache2
Diff against target: 88 lines (+41/-0)
4 files modified
README.md (+5/-0)
config.yaml (+4/-0)
hooks/hooks.py (+4/-0)
hooks/tests/test_create_vhost.py (+28/-0)
To merge this branch: bzr merge lp://staging/~bloodearnest/charms/trusty/apache2/vhost_template_vars
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Review via email: mp+251262@code.staging.launchpad.net

Commit message

Add vhost_template_vars, so you can customise the vhost a bit more per enviroment

Description of the change

Add vhost_template_vars, so you can customise the vhost a bit more per enviroment (dev, staging, prod) without having to maintain separate templates or pre-rendering for each env before you set (as we currently do)

To post a comment you must log in.
Revision history for this message
Tom Haddon (mthaddon) wrote :

Looks like a nice addition. Could you add something to the README.md explaining how this works?

Revision history for this message
Tom Haddon (mthaddon) wrote :

Looks good, merging.

review: Approve
lp://staging/~bloodearnest/charms/trusty/apache2/vhost_template_vars updated
62. By Tom Haddon

[bloodearnest,r=mthaddon] Add vhost_template_vars, so you can customise the vhost a bit more per enviroment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: