Merge lp://staging/~blake-rouse/maas/fix-networking-add-ui into lp://staging/~maas-committers/maas/trunk
Proposed by
Blake Rouse
| Status: | Merged |
|---|---|
| Approved by: | Blake Rouse |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 5095 |
| Proposed branch: | lp://staging/~blake-rouse/maas/fix-networking-add-ui |
| Merge into: | lp://staging/~maas-committers/maas/trunk |
| Diff against target: |
1825 lines (+544/-973) 14 files modified
src/maasserver/static/css/maas-styles.css (+1/-1) src/maasserver/static/js/angular/controllers/networks_list.js (+60/-153) src/maasserver/static/js/angular/controllers/tests/test_networks_list.js (+298/-224) src/maasserver/static/js/angular/directives/maas_obj_form.js (+13/-5) src/maasserver/static/js/angular/directives/model_field.js (+0/-159) src/maasserver/static/js/angular/directives/tests/test_maas_obj_form.js (+37/-1) src/maasserver/static/js/angular/directives/tests/test_model_field.js (+0/-331) src/maasserver/static/partials/networks-list.html (+88/-89) src/maasserver/static/partials/space-details.html (+2/-2) src/maasserver/static/partials/subnet-details.html (+8/-6) src/maasserver/static/scss/maas/components/_forms.scss (+4/-1) src/maasserver/views/combo.py (+0/-1) src/maasserver/websockets/handlers/tests/test_vlan.py (+20/-0) src/maasserver/websockets/handlers/vlan.py (+13/-0) |
| To merge this branch: | bzr merge lp://staging/~blake-rouse/maas/fix-networking-add-ui |
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mike Pontillo (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix the add actions on the networking listing to actually work and pass the values of the fields over the websocket. Fix IP range WebUI issues that where identified during design QA.
The network listing actions now use the maas-obj-form directive that provide errors on fields as well as whole form errors in the dropdown.
To post a comment you must log in.
Revision history for this message
| Mike Pontillo (mpontillo) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks much improved!
One issue I found: adding a VLAN fails and results in an error, 'Cannot assign "4": "VLAN.fabric" must be a "Fabric" instance.'
One suggestion: when you add a space, since it won't be associated with any fabrics it won't be visible in the default list. It would be nice to do something like $location.