MAAS

Merge lp://staging/~blake-rouse/maas/fix-1401349 into lp://staging/~maas-committers/maas/trunk

  1. fix-1401349
  2. Merge into trunk
Proposed by Blake Rouse
Status: Merged
Approved by: Blake Rouse
Approved revision: no longer in the source branch.
Merged at revision: 3418
Proposed branch: lp://staging/~blake-rouse/maas/fix-1401349
Merge into: lp://staging/~maas-committers/maas/trunk
Diff against target: 24 lines (+2/-2)
2 files modified
src/maasserver/templates/maasserver/node_view.html (+1/-1)
src/maasserver/views/tests/test_nodes.py (+1/-1)
To merge this branch: bzr merge lp://staging/~blake-rouse/maas/fix-1401349
Reviewer Review Type Date Requested Status
Jason Hobbs (community) Approve
Review via email: mp+244434@code.staging.launchpad.net

Commit message

Fix node_view to use display_memory and adjust units to GiB.

To post a comment you must log in.
Revision history for this message
Jason Hobbs (jason-hobbs) wrote :

Looks fine but there should be a test right?

review: Approve
Revision history for this message
Raphaël Badin (rvb) wrote :

It's unfortunate that we display the memory using in one unit on the view page and let the user change the value using a different unit on the edit page. It's these little inconsistencies that make an interface clumsy.

Now, I understand this is kind of an emergency fix but please file a low priority bug about this.

Revision history for this message
Blake Rouse (blake-rouse) wrote :

Forgot the test. I have fixed the test.

The issue of displaying in one value and allowing the user to update it in another, will hopefully be fixed in the new node page in 1.8.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.