Checkbox

Merge lp://staging/~bladernr/checkbox/checkbox-fix-optical-tests into lp://staging/checkbox

checkbox-fix-optical-tests
Merge into trunk

Proposed by Jeff Lane  on 2011-09-20

Status:

Merged

Merged at revision:

1056

Proposed branch:

lp://staging/~bladernr/checkbox/checkbox-fix-optical-tests

Merge into:

lp://staging/checkbox

Diff against target:

24 lines (+3/-3)

1 file modified

data/whitelists/default.whitelist (+3/-3)

To merge this branch:

bzr merge lp://staging/~bladernr/checkbox/checkbox-fix-optical-tests

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Manrique (community)		2011-09-20	Needs Information on 2011-09-20
Review via email: mp+76250@code.staging.launchpad.net

Description of the change

fixed default.whitelist to use the correct optical test names.

Revision history for this message

Jeff Lane  (bladernr) wrote on 2011-09-20:

Also: removed suspend/bluetooth_before_suspend from whitelist as that test also no longer exists in checkbox but was left in default.whitelist

lp://staging/~bladernr/checkbox/checkbox-fix-optical-tests updated on 2011-09-20

1054. By Jeff Lane  on 2011-09-20: found another minor issue with the default.whitelist. Removed suspend/bluetooth_before_suspend from the list as that test no longer exists.

Revision history for this message

Daniel Manrique (roadmr) wrote on 2011-09-20:

The name changes for the optical drive tests look good to me.

Regarding the suspend/bluetooth_before_suspend, it indeed no longer exists, but I notice suspend/bluetooth_detect_after_suspend remains, and as per its definition it will always fail, thus causing problems :(

What it does is compare the address of the bluetooth device to the one logged by the before_suspend test, obviously if the before_suspend one didn't run, the file won't exist and grep will complain.

So this test (suspend/bluetooth_detect_after_suspend) should at least be removed from the whitelist too.

I'm curious, why did we axe bluetooth_before_suspend in the first place? I remember fixing it not so long ago...

review: Needs Information