Checkbox

Merge lp://staging/~bladernr/checkbox/add-hypervisor-whitelist into lp://staging/checkbox

add-hypervisor-whitelist
Merge into trunk

Proposed by Jeff Lane  on 2015-08-03

Status:	Merged
Approved by:	Zygmunt Krynicki on 2015-08-06
Approved revision:	3933
Merged at revision:	3935
Proposed branch:	lp://staging/~bladernr/checkbox/add-hypervisor-whitelist
Merge into:	lp://staging/checkbox
Diff against target:	950 lines (+435/-419) 16 files modified providers/plainbox-provider-certification-server/units/network-only.pxu (+43/-0) providers/plainbox-provider-certification-server/units/server-full-14.04.pxu (+90/-0) providers/plainbox-provider-certification-server/units/server-functional-14.04.pxu (+85/-0) providers/plainbox-provider-certification-server/units/server-soc-cert.pxu (+80/-0) providers/plainbox-provider-certification-server/units/storage-only.pxu (+51/-0) providers/plainbox-provider-certification-server/units/usb-only.pxu (+40/-0) providers/plainbox-provider-certification-server/units/virtual-machine-full-14.04.pxu (+4/-4) providers/plainbox-provider-certification-server/units/virtualization-only.pxu (+39/-0) providers/plainbox-provider-certification-server/whitelists/README (+3/-0) providers/plainbox-provider-certification-server/whitelists/network-only.whitelist (+0/-41) providers/plainbox-provider-certification-server/whitelists/server-full-14.04.whitelist (+0/-88) providers/plainbox-provider-certification-server/whitelists/server-functional-14.04.whitelist (+0/-83) providers/plainbox-provider-certification-server/whitelists/server-soc-cert.whitelist (+0/-76) providers/plainbox-provider-certification-server/whitelists/storage-only.whitelist (+0/-49) providers/plainbox-provider-certification-server/whitelists/usb-only.whitelist (+0/-38) providers/plainbox-provider-certification-server/whitelists/virtualization-only.whitelist (+0/-40)
To merge this branch:	bzr merge lp://staging/~bladernr/checkbox/add-hypervisor-whitelist
Related bugs:	Link a bug report
Related blueprints:	Cells host mapping (Medium)

Reviewer	Date Requested	Status
Zygmunt Krynicki (community)	2015-08-03	Approve on 2015-08-06
Jeff Lane 		Needs Resubmitting on 2015-08-05
Review via email: mp+266794@code.staging.launchpad.net

Description of the change

Just adds a Hypervisor cert whitelist to the Server provider

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2015-08-05:

Could we please have a test plan instead? If you have any concerns as to how to create one look at the manual page (plainbox-test-plan-units) or ask us on the irc channel.

review: Needs Fixing

lp://staging/~bladernr/checkbox/add-hypervisor-whitelist updated on 2015-08-05

3933. By Jeff Lane  on 2015-08-05: Took the liberty of converting all whitelists to Test Plan units to avoid constantly being bothered by other devs who say 'please convert blah blah whitelist to a test plan'

Revision history for this message

Jeff Lane  (bladernr) wrote on 2015-08-05:

Instead, I took the liberty of just converting all whitelists in the server provider to test plans. The diff is significantly longer now, but we should no longer need to worry about converting them ad-hoc as changes are made.

manage.py validate says everything looks good, but please sanity check it for me :D

review: Needs Resubmitting

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2015-08-06:

Looks good, thanks a lot :-)

review: Approve