checkbox-certification

Merge lp://staging/~bladernr/checkbox-certification/merge-client-cert-whitelists into lp://staging/checkbox-certification

  1. merge-client-cert-whitelists
  2. Merge into trunk
Proposed by Jeff Lane 
Status: Merged
Merged at revision: 547
Proposed branch: lp://staging/~bladernr/checkbox-certification/merge-client-cert-whitelists
Merge into: lp://staging/checkbox-certification
Diff against target: 365 lines (+114/-92)
6 files modified
data/client-cert.whitelist (+53/-31)
data/client-selftest.whitelist (+53/-31)
data/client-stress.whitelist (+0/-29)
data/server-cert.whitelist (+1/-0)
data/server-selftest.whitelist (+1/-0)
debian/changelog (+6/-1)
To merge this branch: bzr merge lp://staging/~bladernr/checkbox-certification/merge-client-cert-whitelists
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Jeff Lane  Needs Resubmitting
Brendan Donegan (community) Needs Fixing
Review via email: mp+128939@code.staging.launchpad.net

Description of the change

Final?? move of the client stress jobs into client whitelists.

1: Moved the stress jobs and ONLY the stress jobs, no duplicates, into client-cert and client-selftest whitelists.
2: Moved the lengthy automated tests to the end of the whitelist so they run after functional testing
3: Put the reboot/poweroff tests between the suspend jobs and the automated jobs. This allows us to reboot the system into a clean state before starting the automated/stress jobs. This was decided at the sprint.
4: Added in the touchpad_scroll resource that was missing from the whitelists, causing the touchpad scroll tests to be skipped.
5: Added comments to each section where I moved jobs to the automated section.

All this was done in a series of mini-commits. I thought it might make review a bit easier. I have also manually tested both of the client whitelists now to verify that they are working properly.

To post a comment you must log in.
lp://staging/~bladernr/checkbox-certification/merge-client-cert-whitelists updated
544. By Brendan Donegan

Fix bug 1064821 by adding touchpad_scroll resource to whitelists and introduce environment job intro client-cert whitelist from which it was missing

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Note that Ara wanted the touchpad_scroll and environment job additions merged sooner rather than later, so please do merge from trunk and update accordingly.

review: Needs Fixing
lp://staging/~bladernr/checkbox-certification/merge-client-cert-whitelists updated
545. By Jeff Lane 

Merged my branch into a fresh copy of trunk to include changes made to trunk that caused conflicts in my branch

546. By Jeff Lane 

Merged the client-stress tests into the client cert and self-test whitelists. Moved most of the automated tests to the end of the client whitelists as well. Additionally, took the opportunity to add the environment resource to the server whitelists.

Revision history for this message
Jeff Lane  (bladernr) wrote :

Ok... no worries. I've merged my branch into a fresh copy of trunk and pushed the changes.

review: Needs Resubmitting
Revision history for this message
Marc Tardif (cr3) wrote :

1. Renamed ___cpu__, notice the triple underscores, to __cpu__, with only double underscores.
2. Moved sleep and audio/list_devices jobs so that both client-cert and client-selftest whitelists are more similar.
3. I also took the opportunity to sort the resource jobs at the top of the whitelists, there's really no reason to have them in any particular order and it just makes it easier to compare whitelists. This actually enabled me to notice that the environment resource appeared twice in the server whitelists when merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches