Merge lp://staging/~black-perl/mailman.client/handling-special-chars-in-email into lp://staging/mailman.client
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~black-perl/mailman.client/handling-special-chars-in-email |
| Merge into: | lp://staging/mailman.client |
| Diff against target: |
157 lines (+47/-12) 2 files modified
src/mailmanclient/_client.py (+25/-12) src/mailmanclient/utils.py (+22/-0) |
| To merge this branch: | bzr merge lp://staging/~black-perl/mailman.client/handling-special-chars-in-email |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mailman Coders | Pending | ||
|
Review via email:
|
|||
Description of the change
As discussed in the bug report, use of emails with special character set is valid as per email RFCs but postorius crashes on using them giving 404 or KeyError always.
As discussed on the mailing list a possible solution would be to percent encode these special characters when they appear in the list_id or fqdn_listname before sending a request to the REST server and decoding on the other end.
Added utils.py which has to functions `encode` and `encode_url` to faciliate encoding of list_id's in URLs when required.
The use of special characters in list_ids is working properly http://
Unmerged revisions
- 63. By black-perl <email address hidden>
-
Added utils.py containing functions for encoding urls. Added support for encoding the list_id or fqdn_listname as per the issue #1429366 in _client.py.
