Merge lp://staging/~bjornt/lp2kanban/no-sync-lanes into lp://staging/~launchpad/lp2kanban/trunk

Proposed by Björn Tillenius
Status: Merged
Merged at revision: 81
Proposed branch: lp://staging/~bjornt/lp2kanban/no-sync-lanes
Merge into: lp://staging/~launchpad/lp2kanban/trunk
Diff against target: 195 lines (+81/-21) (has conflicts)
4 files modified
examples/config.ini (+7/-2)
src/lp2kanban/bugs2cards.py (+14/-5)
src/lp2kanban/tests/common.py (+2/-1)
src/lp2kanban/tests/test_bugs2cards.py (+58/-13)
Text conflict in src/lp2kanban/bugs2cards.py
To merge this branch: bzr merge lp://staging/~bjornt/lp2kanban/no-sync-lanes
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+157379@code.staging.launchpad.net

Description of the change

Add a no_sync_lanes config option for not syncing certain lanes.

It's similar to manual_lanes, which I renamed to no_move_lanes,
to make it more consistent.

Cards in those lanes won't get synced at all. This is useful
to avoid having it process the Archive, which can take quite
a while.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

This sentence is clumsy:

s/Cards that won't be synced won't also be moved./
  Cards that won't be synced also won't be moved./

I'm a bit concerned by the renaming of a configuration option (manual_lanes) but I see you added it a while back and suspect no one but you is using it. So it probably isn't a big deal, though it would be if we thought there were deployed configurations using that setting.

I like the new no_sync_lanes and may use it for our board. Grahams needs to look at the archive for his blueprint work but it causes us to spend lots of time processing archive. Thanks for the addition.

review: Approve (code)
81. By Björn Tillenius

Fix grammar.

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Fri, Apr 05, 2013 at 06:57:23PM -0000, Brad Crittenden wrote:
> Review: Approve code
>
> This sentence is clumsy:
>
> s/Cards that won't be synced won't also be moved./
> Cards that won't be synced also won't be moved./

Thanks, fixed.

> I'm a bit concerned by the renaming of a configuration option
> (manual_lanes) but I see you added it a while back and suspect no one
> but you is using it. So it probably isn't a big deal, though it would
> be if we thought there were deployed configurations using that setting.

Yeah, I would be surprised if anyone used manual_lanes but me, so I
didn't add support for that name.

--
Björn Tillenius | https://launchpad.net/~bjornt

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches