Merge lp://staging/~bjornt/landscape-client/systemerror-no-retry into lp://staging/~landscape/landscape-client/trunk
Proposed by
Björn Tillenius
| Status: | Merged |
|---|---|
| Approved by: | Björn Tillenius |
| Approved revision: | 817 |
| Merged at revision: | 817 |
| Proposed branch: | lp://staging/~bjornt/landscape-client/systemerror-no-retry |
| Merge into: | lp://staging/~landscape/landscape-client/trunk |
| Diff against target: |
82 lines (+30/-13) 2 files modified
landscape/package/facade.py (+6/-2) landscape/package/tests/test_facade.py (+24/-11) |
| To merge this branch: | bzr merge lp://staging/~bjornt/landscape-client/systemerror-no-retry |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chad Smith | Approve | ||
| Alberto Donato | Approve | ||
|
Review via email:
|
|||
Commit message
Don't retry package operations if a SystemError is raised, since a
SystemError is most likely a permanent error and retrying won't help.
The original patch to retry the operation was to handle lock errors,
which are still properly retried with this branch.
Description of the change
Don't retry package operations if a SystemError is raised, since a
SystemError is most likely a permanent error and retrying won't help.
The original patch to retry the operation was to handle lock errors,
which are properly retried with this branch.
I tested that retrying lock errors still works in both trusty and lucid.
To post a comment you must log in.
Revision history for this message
| Adam Collard (adam-collard) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
nice fix, +1
One nitpick inline