Merge lp://staging/~bjornt/charms/trusty/ceph-radosgw/apt-cache-memonly into lp://staging/~openstack-charmers-archive/charms/trusty/ceph-radosgw/next

Proposed by James Page
Status: Merged
Merged at revision: 23
Proposed branch: lp://staging/~bjornt/charms/trusty/ceph-radosgw/apt-cache-memonly
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/ceph-radosgw/next
Diff against target: 35 lines (+9/-5)
1 file modified
hooks/ceph.py (+9/-5)
To merge this branch: bzr merge lp://staging/~bjornt/charms/trusty/ceph-radosgw/apt-cache-memonly
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+227889@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-07-23.

Description of the change

Build the Apt cache in memory when checking the ceph version.

This avoids a race condition where something else is rebuilding
the Apt cache in the same directory.

I also changed the imports, so it's clear that it's the apt_pkg
that is being used. There's another module called apt, which
provides a different API, and importing apt_pkg as apt has
fooled me more than once.

To post a comment you must log in.
Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches