Merge lp://staging/~bjornt/charms/precise/landscape-client/apt-retry into lp://staging/charms/landscape-client

Proposed by Björn Tillenius
Status: Merged
Approved by: Björn Tillenius
Approved revision: 39
Merged at revision: 38
Proposed branch: lp://staging/~bjornt/charms/precise/landscape-client/apt-retry
Merge into: lp://staging/charms/landscape-client
Diff against target: 34 lines (+23/-3)
1 file modified
hooks/install (+23/-3)
To merge this branch: bzr merge lp://staging/~bjornt/charms/precise/landscape-client/apt-retry
Reviewer Review Type Date Requested Status
Chris Glass Approve
David Britton Approve
Review via email: mp+218891@code.staging.launchpad.net

Commit message

Retry apt-get if the lock can't be aquired. If we get an error from
apt-get we'll retry for 5 minutes.

Currently the code retries on any error, since I couldn't see an
easy way of checking for locking errors only.

Description of the change

Retry apt-get if the lock can't be aquired. If we get an error from
apt-get we'll retry for 5 minutes.

Currently the code retries on any error, since I couldn't see an
easy way of checking for locking errors only.

To post a comment you must log in.
Revision history for this message
David Britton (dpb) wrote :

[0] "...retry command for 30 attempts (~ 5 minutes)"

Revision history for this message
David Britton (dpb) wrote :

+1, looks good.

review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

Looks good! +1

review: Approve
39. By Björn Tillenius

Improve comment.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches