OpenStack Charm Testing

Merge lp://staging/~billy-olsen/openstack-charm-testing/idempotent-post-deploy-config into lp://staging/openstack-charm-testing

idempotent-post-deploy-config
Merge into trunk

Proposed by Billy Olsen on 2016-11-02

Status:	Merged
Merged at revision:	271
Proposed branch:	lp://staging/~billy-olsen/openstack-charm-testing/idempotent-post-deploy-config
Merge into:	lp://staging/openstack-charm-testing
Diff against target:	125 lines (+61/-7) 3 files modified bin/post-deploy-config (+59/-5) tools/quota_high.sh (+1/-1) tools/quota_million.sh (+1/-1)
To merge this branch:	bzr merge lp://staging/~billy-olsen/openstack-charm-testing/idempotent-post-deploy-config
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Ryan Beisner		Approve on 2017-02-02
Edward Hope-Morley	2016-11-02	Needs Fixing on 2016-11-10
Review via email: mp+309807@code.staging.launchpad.net

Revision history for this message

Edward Hope-Morley (hopem) wrote on 2016-11-10:

Just ran this and I got the following error:

+ ./bin/post-deploy-config neutron-gateway
Using default network name: hopem_admin_net
Traceback (most recent call last):
  File "./bin/post-deploy-config", line 80, in <module>
    config_ports = get_data_port_config(juju_version, service)
  File "./bin/post-deploy-config", line 17, in get_data_port_config
    data_ports = config['settings']['data-port']['value']
KeyError: 'value'

review: Needs Fixing

lp://staging/~billy-olsen/openstack-charm-testing/idempotent-post-deploy-config updated on 2016-11-10

256. By Billy Olsen on 2016-11-10: On initial deployment, the default value for the data ports will be empty
and therefore parsing the get-config doesn't contain the value output.
This changes the code to tolerate that.

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2017-02-02:

Thank you for your work on this. Fixing lint on the way in. ;-)

bin/post-deploy-config:19:23: F821 undefined name 'data_port_settings'
bin/post-deploy-config:75:1: W293 blank line contains whitespace
bin/post-deploy-config:89:1: W293 blank line contains whitespace
bin/post-deploy-config:94:1: W293 blank line contains whitespace
bin/post-deploy-config:115:1: W293 blank line contains whitespace